Commit 6f4eaea2 authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab
Browse files

media: cobalt: fix initial EDID 



The EDID failed with two edid-decode warnings:

Block 1, CTA-861 Extension Block:
  Video Data Block: VIC 16 is the preferred timing, overriding the first detailed timings. Is this intended?
  Video Capability Data Block: S_PT is equal to S_IT and S_CE, so should be set to 0 instead.

In addition, the first DTD had a wrong vsync value (6 instead of 5).

Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 154bee9b

drivers/media/pci/cobalt/cobalt-driver.c

+5 −5
Original line number Diff line number Diff line
@@ -56,19 +56,19 @@ static u8 edid[256] = { 
	0x45, 0x59, 0x61, 0x59, 0x81, 0x99, 0x01, 0x01,

	0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x02, 0x3a,

	0x80, 0x18, 0x71, 0x38, 0x2d, 0x40, 0x58, 0x2c,

	0x46, 0x00, 0xe0, 0x0e, 0x11, 0x00, 0x00, 0x1e,

	0x45, 0x00, 0xe0, 0x0e, 0x11, 0x00, 0x00, 0x1e,

	0x00, 0x00, 0x00, 0xfd, 0x00, 0x18, 0x55, 0x18,

	0x5e, 0x11, 0x00, 0x0a, 0x20, 0x20, 0x20, 0x20,

	0x20, 0x20, 0x00, 0x00, 0x00, 0xfc, 0x00, 0x63,

	0x6f, 0x62, 0x61, 0x6c, 0x74, 0x0a, 0x20, 0x20,

	0x20, 0x20, 0x20, 0x20, 0x00, 0x00, 0x00, 0x10,

	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,

	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x9c,

	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x9d,



	0x02, 0x03, 0x1f, 0xf0, 0x4a, 0x90, 0x1f, 0x04,

	0x02, 0x03, 0x1f, 0xf1, 0x4a, 0x10, 0x1f, 0x04,

	0x13, 0x22, 0x21, 0x20, 0x02, 0x11, 0x01, 0x23,

	0x09, 0x07, 0x07, 0x68, 0x03, 0x0c, 0x00, 0x10,

	0x00, 0x00, 0x22, 0x0f, 0xe2, 0x00, 0xea, 0x00,

	0x00, 0x00, 0x22, 0x0f, 0xe2, 0x00, 0xca, 0x00,

	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,

	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,

	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
@@ -80,7 +80,7 @@ static u8 edid[256] = { 
	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,

	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,

	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,

	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xa7,

	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x46,

};



static void cobalt_set_interrupt(struct cobalt *cobalt, bool enable)