Commit 6feb634f authored by Bryan O'Donoghue's avatar Bryan O'Donoghue Committed by Kalle Valo
Browse files

wcn36xx: Do not flush indication queue on suspend/resume 



Testing on Android reveals that the flush on both suspend and resume of the
firmware indication work-queue can stall indefinitely.

Given this code path doesn't appear to have been exercised up until now,
removing this flush to unblock this situation.

Signed-off-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
Tested-by: default avatarBenjamin Li <benl@squareup.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210605011140.2004643-5-bryan.odonoghue@linaro.org
parent 5478c41f

drivers/net/wireless/ath/wcn36xx/main.c

+0 −2
Original line number Diff line number Diff line
@@ -1110,7 +1110,6 @@ static int wcn36xx_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wow) 


	wcn36xx_dbg(WCN36XX_DBG_MAC, "mac suspend\n");



	flush_workqueue(wcn->hal_ind_wq);

	mutex_lock(&wcn->conf_mutex);



	vif = wcn36xx_get_first_assoc_vif(wcn);
@@ -1132,7 +1131,6 @@ static int wcn36xx_resume(struct ieee80211_hw *hw) 


	wcn36xx_dbg(WCN36XX_DBG_MAC, "mac resume\n");



	flush_workqueue(wcn->hal_ind_wq);

	mutex_lock(&wcn->conf_mutex);

	vif = wcn36xx_get_first_assoc_vif(wcn);

	if (vif) {