Commit 7034ca4d authored Dec 24, 2008 by Julia Lawall Committed by Greg Kroah-Hartman Apr 03, 2009

Staging: rt2860,rt2870: Correct use of ! and &

IW_ENCODE_MODE is 0xF000 and thus !erq->flags & IW_ENCODE_MODE is always 0.
I assume that !(erq->flags & IW_ENCODE_MODE) was intended.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/

)

// <smpl>
@@ expression E; constant C; @@
(
  !E & !C
|
- !E & C
+ !(E & C)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 88adc104

drivers/staging/rt2860/sta_ioctl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1756,7 +1756,7 @@ int rt_ioctl_siwencode(struct net_device *dev,
		}
		else
		/* Don't complain if only change the mode */
		if(!erq->flags & IW_ENCODE_MODE) {
		if (!(erq->flags & IW_ENCODE_MODE)) {
		return -EINVAL;
		}
		}

drivers/staging/rt2870/sta_ioctl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1776,7 +1776,7 @@ int rt_ioctl_siwencode(struct net_device *dev,
		}
		else
		/* Don't complain if only change the mode */
		if(!erq->flags & IW_ENCODE_MODE) {
		if (!(erq->flags & IW_ENCODE_MODE)) {
		return -EINVAL;
		}
		}