Commit 7069d105 authored by Ye Bin's avatar Ye Bin Committed by Theodore Ts'o
Browse files

ext4: fix potential memory leak in ext4_fc_record_regions() 



As krealloc may return NULL, in this case 'state->fc_regions' may not be
freed by krealloc, but 'state->fc_regions' already set NULL. Then will
lead to 'state->fc_regions' memory leak.

Cc: stable@kernel.org
Signed-off-by: default avatarYe Bin <yebin10@huawei.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220921064040.3693255-3-yebin10@huawei.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 9305721a

fs/ext4/fast_commit.c

+8 −6
Original line number Diff line number Diff line
@@ -1679,15 +1679,17 @@ int ext4_fc_record_regions(struct super_block *sb, int ino, 
	if (replay && state->fc_regions_used != state->fc_regions_valid)

		state->fc_regions_used = state->fc_regions_valid;

	if (state->fc_regions_used == state->fc_regions_size) {

		struct ext4_fc_alloc_region *fc_regions;



		state->fc_regions_size +=

			EXT4_FC_REPLAY_REALLOC_INCREMENT;

		state->fc_regions = krealloc(

					state->fc_regions,

		fc_regions = krealloc(state->fc_regions,

				      state->fc_regions_size *

				      sizeof(struct ext4_fc_alloc_region),

				      GFP_KERNEL);

		if (!state->fc_regions)

		if (!fc_regions)

			return -ENOMEM;

		state->fc_regions = fc_regions;

	}

	region = &state->fc_regions[state->fc_regions_used++];

	region->ino = ino;