Commit 707554b4 authored by Ola Olsson's avatar Ola Olsson Committed by Johannes Berg
Browse files

nl80211: Fix potential memory leak in nl80211_connect 



Free cached keys if the last early return path is taken.

Signed-off-by: default avatarOla Olsson <ola.olsson@sonymobile.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent e5dbe070

net/wireless/nl80211.c

+3 −1
Original line number Diff line number Diff line
@@ -7941,8 +7941,10 @@ static int nl80211_connect(struct sk_buff *skb, struct genl_info *info) 
	if (nla_get_flag(info->attrs[NL80211_ATTR_USE_RRM])) {

		if (!(rdev->wiphy.features &

		      NL80211_FEATURE_DS_PARAM_SET_IE_IN_PROBES) ||

		    !(rdev->wiphy.features & NL80211_FEATURE_QUIET))

		    !(rdev->wiphy.features & NL80211_FEATURE_QUIET)) {

			kzfree(connkeys);

			return -EINVAL;

		}

		connect.flags |= ASSOC_REQ_USE_RRM;

	}