Commit 70dd83d7 authored by Chen-Tsung Hsieh's avatar Chen-Tsung Hsieh Committed by Pratyush Yadav
Browse files

mtd: spi-nor: core: Check written SR value in spi_nor_write_16bit_sr_and_check() 



Read back Status Register 1 to ensure that the written byte match the
received value and return -EIO if read back test failed.

Without this patch, spi_nor_write_16bit_sr_and_check() only check the
second half of the 16bit. It causes errors like spi_nor_sr_unlock()
return success incorrectly when spi_nor_write_16bit_sr_and_check()
doesn't write SR successfully.

Fixes: 39d1e334 ("mtd: spi-nor: Fix clearing of QE bit on lock()/unlock()")
Signed-off-by: default avatarChen-Tsung Hsieh <chentsung@chromium.org>
Signed-off-by: default avatarPratyush Yadav <p.yadav@ti.com>
Reviewed-by: default avatarMichael Walle <michael@walle.cc>
Reviewed-by: default avatarTudor Ambarus <tudor.ambarus@microchip.com>
Acked-by: default avatarPratyush Yadav <p.yadav@ti.com>
Link: https://lore.kernel.org/r/20220126073227.3401275-1-chentsung@chromium.org
parent b2d229d4

drivers/mtd/spi-nor/core.c

+9 −0
Original line number Diff line number Diff line
@@ -788,6 +788,15 @@ static int spi_nor_write_16bit_sr_and_check(struct spi_nor *nor, u8 sr1) 
	if (ret)

		return ret;



	ret = spi_nor_read_sr(nor, sr_cr);

	if (ret)

		return ret;



	if (sr1 != sr_cr[0]) {

		dev_dbg(nor->dev, "SR: Read back test failed\n");

		return -EIO;

	}



	if (nor->flags & SNOR_F_NO_READ_CR)

		return 0;