Commit 71d3edc6 authored by Fabio M. De Francesco's avatar Fabio M. De Francesco Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: Remove led_blink_hdl() and everything related 



Removed useless led_blink_hdl() prototype and definition.
Removed struct LedBlink_param. Removed LedBlink entries in
rtw_cmd_callback[] and in wlancmds[]. Everything related to LedBlink is
not anymore needed. Index of slots changed in arrays comments to reflect
current positions.

Reported-by: default avatarJulia Lawall <julia.lawall@inria.fr>
Reported-by: default avatarFabio Aiuto <fabioaiuto83@gmail.com>
Reported-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: default avatarMatthew Wilcox <willy@infradead.org>
Suggested-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarFabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20210415071731.25725-1-fmdefrancesco@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8ffdff6a

drivers/staging/rtl8723bs/core/rtw_cmd.c

+7 −9
Original line number Diff line number Diff line
@@ -78,13 +78,12 @@ static struct _cmd_callback rtw_cmd_callback[] = { 
	{GEN_CMD_CODE(_Set_Drv_Extra), NULL},/*57*/

	{GEN_CMD_CODE(_Set_H2C_MSG), NULL},/*58*/

	{GEN_CMD_CODE(_SetChannelPlan), NULL},/*59*/

	{GEN_CMD_CODE(_LedBlink), NULL},/*60*/



	{GEN_CMD_CODE(_SetChannelSwitch), NULL},/*61*/

	{GEN_CMD_CODE(_TDLS), NULL},/*62*/

	{GEN_CMD_CODE(_ChkBMCSleepq), NULL}, /*63*/

	{GEN_CMD_CODE(_SetChannelSwitch), NULL},/*60*/

	{GEN_CMD_CODE(_TDLS), NULL},/*61*/

	{GEN_CMD_CODE(_ChkBMCSleepq), NULL}, /*62*/



	{GEN_CMD_CODE(_RunInThreadCMD), NULL},/*64*/

	{GEN_CMD_CODE(_RunInThreadCMD), NULL},/*63*/

};



static struct cmd_hdl wlancmds[] = {
@@ -150,11 +149,10 @@ static struct cmd_hdl wlancmds[] = { 


	GEN_MLME_EXT_HANDLER(0, h2c_msg_hdl) /*58*/

	GEN_MLME_EXT_HANDLER(sizeof(struct SetChannelPlan_param), set_chplan_hdl) /*59*/

	GEN_MLME_EXT_HANDLER(sizeof(struct LedBlink_param), led_blink_hdl) /*60*/



	GEN_MLME_EXT_HANDLER(sizeof(struct SetChannelSwitch_param), set_csa_hdl) /*61*/

	GEN_MLME_EXT_HANDLER(sizeof(struct TDLSoption_param), tdls_hdl) /*62*/

	GEN_MLME_EXT_HANDLER(0, chk_bmc_sleepq_hdl) /*63*/

	GEN_MLME_EXT_HANDLER(sizeof(struct SetChannelSwitch_param), set_csa_hdl) /*60*/

	GEN_MLME_EXT_HANDLER(sizeof(struct TDLSoption_param), tdls_hdl) /*61*/

	GEN_MLME_EXT_HANDLER(0, chk_bmc_sleepq_hdl) /*62*/

	GEN_MLME_EXT_HANDLER(sizeof(struct RunInThread_param), run_in_thread_hdl) /*63*/

};

drivers/staging/rtl8723bs/core/rtw_mlme_ext.c

+0 −9
Original line number Diff line number Diff line
@@ -6189,15 +6189,6 @@ u8 set_chplan_hdl(struct adapter *padapter, unsigned char *pbuf) 
	return	H2C_SUCCESS;

}



u8 led_blink_hdl(struct adapter *padapter, unsigned char *pbuf)

{



	if (!pbuf)

		return H2C_PARAMETERS_ERROR;



	return	H2C_SUCCESS;

}



u8 set_csa_hdl(struct adapter *padapter, unsigned char *pbuf)

{

	return	H2C_REJECTED;

drivers/staging/rtl8723bs/include/rtw_cmd.h

+4 −10
Original line number Diff line number Diff line
@@ -537,11 +537,6 @@ struct SetChannelPlan_param { 
	u8 channel_plan;

};



/*H2C Handler index: 60 */

struct LedBlink_param {

	void *pLed;

};



/*H2C Handler index: 61 */

struct SetChannelSwitch_param {

	u8 new_ch_no;
@@ -709,13 +704,12 @@ enum { 
	GEN_CMD_CODE(_Set_H2C_MSG), /*58*/



	GEN_CMD_CODE(_SetChannelPlan), /*59*/

	GEN_CMD_CODE(_LedBlink), /*60*/



	GEN_CMD_CODE(_SetChannelSwitch), /*61*/

	GEN_CMD_CODE(_TDLS), /*62*/

	GEN_CMD_CODE(_ChkBMCSleepq), /*63*/

	GEN_CMD_CODE(_SetChannelSwitch), /*60*/

	GEN_CMD_CODE(_TDLS), /*61*/

	GEN_CMD_CODE(_ChkBMCSleepq), /*62*/



	GEN_CMD_CODE(_RunInThreadCMD), /*64*/

	GEN_CMD_CODE(_RunInThreadCMD), /*63*/



	MAX_H2CCMD

};

drivers/staging/rtl8723bs/include/rtw_mlme_ext.h

+0 −1
Original line number Diff line number Diff line
@@ -745,7 +745,6 @@ u8 chk_bmc_sleepq_hdl(struct adapter *padapter, unsigned char *pbuf); 
u8 tx_beacon_hdl(struct adapter *padapter, unsigned char *pbuf);

u8 set_ch_hdl(struct adapter *padapter, u8 *pbuf);

u8 set_chplan_hdl(struct adapter *padapter, unsigned char *pbuf);

u8 led_blink_hdl(struct adapter *padapter, unsigned char *pbuf);

u8 set_csa_hdl(struct adapter *padapter, unsigned char *pbuf);	/* Kurt: Handling DFS channel switch announcement ie. */

u8 tdls_hdl(struct adapter *padapter, unsigned char *pbuf);

u8 run_in_thread_hdl(struct adapter *padapter, u8 *pbuf);