Commit 721b79d1 authored by Christian Engelmayer's avatar Christian Engelmayer Committed by Greg Kroah-Hartman
Browse files

staging: vt6656: fix potential leak in vt6656_hostap_ioctl() 



Commit fb841d67 (staging: vt6656: don't leak 'param' in vt6656_hostap_ioctl()
when returning -EOPNOTSUPP) cleaned up direct returns in the ioctl switch
statement that leaked already allocated memory. Fix the same issue for
VIAWGET_HOSTAPD_SCAN_REQ and VIAWGET_HOSTAPD_MLME that are not supported by
this driver. Detected by Coverity - CID 144381.

Signed-off-by: default avatarChristian Engelmayer <cengelma@gmx.at>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 62a3f8a1

drivers/staging/vt6656/hostap.c

+4 −2
Original line number Diff line number Diff line
@@ -742,7 +742,8 @@ int vt6656_hostap_ioctl(struct vnt_private *pDevice, struct iw_point *p) 


	case VIAWGET_HOSTAPD_MLME:

	    DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "VIAWGET_HOSTAPD_MLME \n");

	    return -EOPNOTSUPP;

	    ret = -EOPNOTSUPP;

	    goto out;



	case VIAWGET_HOSTAPD_SET_GENERIC_ELEMENT:

	    DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "VIAWGET_HOSTAPD_SET_GENERIC_ELEMENT \n");
@@ -751,7 +752,8 @@ int vt6656_hostap_ioctl(struct vnt_private *pDevice, struct iw_point *p) 


	case VIAWGET_HOSTAPD_SCAN_REQ:

	    DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "VIAWGET_HOSTAPD_SCAN_REQ \n");

	    return -EOPNOTSUPP;

	    ret = -EOPNOTSUPP;

	    goto out;



	case VIAWGET_HOSTAPD_STA_CLEAR_STATS:

	    DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "VIAWGET_HOSTAPD_STA_CLEAR_STATS \n");