Commit 722a3291 authored by Franziska Naepelt's avatar Franziska Naepelt Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: ioctl_linux: Remove unnecessary parentheses 



Fix the following checkpatch issue:
- CHECK: Unnecessary parentheses around ...

Signed-off-by: default avatarFranziska Naepelt <franziska.naepelt@googlemail.com>
Link: https://lore.kernel.org/r/20230722215850.4353-1-franziska.naepelt@googlemail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5434da83

drivers/staging/rtl8723bs/os_dep/ioctl_linux.c

+29 −29
Original line number Diff line number Diff line
@@ -125,7 +125,7 @@ static int wpa_set_encryption(struct net_device *dev, struct ieee_param *param, 
				goto exit;

			}



			memcpy(&(psecuritypriv->dot11DefKey[wep_key_idx].skey[0]), pwep->key_material, pwep->key_length);

			memcpy(&psecuritypriv->dot11DefKey[wep_key_idx].skey[0], pwep->key_material, pwep->key_length);

			psecuritypriv->dot11DefKeylen[wep_key_idx] = pwep->key_length;

			rtw_set_key(padapter, psecuritypriv, wep_key_idx, 0, true);

		}
@@ -156,8 +156,8 @@ static int wpa_set_encryption(struct net_device *dev, struct ieee_param *param, 


					if (strcmp(param->u.crypt.alg, "TKIP") == 0) { /* set mic key */

						/* DEBUG_ERR(("\nset key length :param->u.crypt.key_len =%d\n", param->u.crypt.key_len)); */

						memcpy(psta->dot11tkiptxmickey.skey, &(param->u.crypt.key[16]), 8);

						memcpy(psta->dot11tkiprxmickey.skey, &(param->u.crypt.key[24]), 8);

						memcpy(psta->dot11tkiptxmickey.skey, &param->u.crypt.key[16], 8);

						memcpy(psta->dot11tkiprxmickey.skey, &param->u.crypt.key[24], 8);



						padapter->securitypriv.busetkipkey = false;

						/* _set_timer(&padapter->securitypriv.tkip_timer, 50); */
@@ -169,8 +169,8 @@ static int wpa_set_encryption(struct net_device *dev, struct ieee_param *param, 
						memcpy(padapter->securitypriv.dot118021XGrpKey[param->u.crypt.idx].skey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 : param->u.crypt.key_len));

						/* only TKIP group key need to install this */

						if (param->u.crypt.key_len > 16) {

							memcpy(padapter->securitypriv.dot118021XGrptxmickey[param->u.crypt.idx].skey, &(param->u.crypt.key[16]), 8);

							memcpy(padapter->securitypriv.dot118021XGrprxmickey[param->u.crypt.idx].skey, &(param->u.crypt.key[24]), 8);

							memcpy(padapter->securitypriv.dot118021XGrptxmickey[param->u.crypt.idx].skey, &param->u.crypt.key[16], 8);

							memcpy(padapter->securitypriv.dot118021XGrprxmickey[param->u.crypt.idx].skey, &param->u.crypt.key[24], 8);

						}

						padapter->securitypriv.binstallGrpkey = true;
@@ -518,7 +518,7 @@ static int rtw_set_encryption(struct net_device *dev, struct ieee_param *param, 
	struct sta_info *psta = NULL, *pbcmc_sta = NULL;

	struct adapter *padapter = rtw_netdev_priv(dev);

	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;

	struct security_priv *psecuritypriv = &(padapter->securitypriv);

	struct security_priv *psecuritypriv = &padapter->securitypriv;

	struct sta_priv *pstapriv = &padapter->stapriv;

	char *txkey = padapter->securitypriv.dot118021XGrptxmickey[param->u.crypt.idx].skey;

	char *rxkey = padapter->securitypriv.dot118021XGrprxmickey[param->u.crypt.idx].skey;
@@ -597,7 +597,7 @@ static int rtw_set_encryption(struct net_device *dev, struct ieee_param *param, 


			psecuritypriv->dot11PrivacyKeyIndex = wep_key_idx;



			memcpy(&(psecuritypriv->dot11DefKey[wep_key_idx].skey[0]), pwep->key_material, pwep->key_length);

			memcpy(&psecuritypriv->dot11DefKey[wep_key_idx].skey[0], pwep->key_material, pwep->key_length);



			psecuritypriv->dot11DefKeylen[wep_key_idx] = pwep->key_length;
@@ -606,7 +606,7 @@ static int rtw_set_encryption(struct net_device *dev, struct ieee_param *param, 
			/* don't update "psecuritypriv->dot11PrivacyAlgrthm" and */

			/* psecuritypriv->dot11PrivacyKeyIndex =keyid", but can rtw_set_key to cam */



			memcpy(&(psecuritypriv->dot11DefKey[wep_key_idx].skey[0]), pwep->key_material, pwep->key_length);

			memcpy(&psecuritypriv->dot11DefKey[wep_key_idx].skey[0], pwep->key_material, pwep->key_length);



			psecuritypriv->dot11DefKeylen[wep_key_idx] = pwep->key_length;
@@ -632,8 +632,8 @@ static int rtw_set_encryption(struct net_device *dev, struct ieee_param *param, 


				/* DEBUG_ERR("set key length :param->u.crypt.key_len =%d\n", param->u.crypt.key_len); */

				/* set mic key */

				memcpy(txkey, &(param->u.crypt.key[16]), 8);

				memcpy(psecuritypriv->dot118021XGrprxmickey[param->u.crypt.idx].skey, &(param->u.crypt.key[24]), 8);

				memcpy(txkey, &param->u.crypt.key[16], 8);

				memcpy(psecuritypriv->dot118021XGrprxmickey[param->u.crypt.idx].skey, &param->u.crypt.key[24], 8);



				psecuritypriv->busetkipkey = true;
@@ -677,8 +677,8 @@ static int rtw_set_encryption(struct net_device *dev, struct ieee_param *param, 


					/* DEBUG_ERR("set key length :param->u.crypt.key_len =%d\n", param->u.crypt.key_len); */

					/* set mic key */

					memcpy(psta->dot11tkiptxmickey.skey, &(param->u.crypt.key[16]), 8);

					memcpy(psta->dot11tkiprxmickey.skey, &(param->u.crypt.key[24]), 8);

					memcpy(psta->dot11tkiptxmickey.skey, &param->u.crypt.key[16], 8);

					memcpy(psta->dot11tkiprxmickey.skey, &param->u.crypt.key[24], 8);



					psecuritypriv->busetkipkey = true;
@@ -706,8 +706,8 @@ static int rtw_set_encryption(struct net_device *dev, struct ieee_param *param, 


					/* DEBUG_ERR("set key length :param->u.crypt.key_len =%d\n", param->u.crypt.key_len); */

					/* set mic key */

					memcpy(txkey, &(param->u.crypt.key[16]), 8);

					memcpy(rxkey, &(param->u.crypt.key[24]), 8);

					memcpy(txkey, &param->u.crypt.key[16], 8);

					memcpy(rxkey, &param->u.crypt.key[24], 8);



					psecuritypriv->busetkipkey = true;
@@ -746,7 +746,7 @@ static int rtw_set_beacon(struct net_device *dev, struct ieee_param *param, int 
{

	int ret = 0;

	struct adapter *padapter = rtw_netdev_priv(dev);

	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);

	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;

	struct sta_priv *pstapriv = &padapter->stapriv;

	unsigned char *pbuf = param->u.bcn_ie.buf;
@@ -784,7 +784,7 @@ static int rtw_add_sta(struct net_device *dev, struct ieee_param *param) 
	int ret = 0;

	struct sta_info *psta = NULL;

	struct adapter *padapter = rtw_netdev_priv(dev);

	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);

	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;

	struct sta_priv *pstapriv = &padapter->stapriv;



	if (check_fwstate(pmlmepriv, (_FW_LINKED|WIFI_AP_STATE)) != true)
@@ -849,7 +849,7 @@ static int rtw_del_sta(struct net_device *dev, struct ieee_param *param) 
	int ret = 0;

	struct sta_info *psta = NULL;

	struct adapter *padapter = rtw_netdev_priv(dev);

	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);

	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;

	struct sta_priv *pstapriv = &padapter->stapriv;



	if (check_fwstate(pmlmepriv, (_FW_LINKED|WIFI_AP_STATE)) != true)
@@ -886,7 +886,7 @@ static int rtw_ioctl_get_sta_data(struct net_device *dev, struct ieee_param *par 
	int ret = 0;

	struct sta_info *psta = NULL;

	struct adapter *padapter = rtw_netdev_priv(dev);

	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);

	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;

	struct sta_priv *pstapriv = &padapter->stapriv;

	struct ieee_param_ex *param_ex = (struct ieee_param_ex *)param;

	struct sta_data *psta_data = (struct sta_data *)param_ex->data;
@@ -945,7 +945,7 @@ static int rtw_get_sta_wpaie(struct net_device *dev, struct ieee_param *param) 
	int ret = 0;

	struct sta_info *psta = NULL;

	struct adapter *padapter = rtw_netdev_priv(dev);

	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);

	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;

	struct sta_priv *pstapriv = &padapter->stapriv;



	if (check_fwstate(pmlmepriv, (_FW_LINKED|WIFI_AP_STATE)) != true)
@@ -983,8 +983,8 @@ static int rtw_set_wps_beacon(struct net_device *dev, struct ieee_param *param, 
	int ret = 0;

	unsigned char wps_oui[4] = {0x0, 0x50, 0xf2, 0x04};

	struct adapter *padapter = rtw_netdev_priv(dev);

	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);

	struct mlme_ext_priv *pmlmeext = &(padapter->mlmeextpriv);

	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;

	struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;

	int ie_len;



	if (check_fwstate(pmlmepriv, WIFI_AP_STATE) != true)
@@ -1015,7 +1015,7 @@ static int rtw_set_wps_probe_resp(struct net_device *dev, struct ieee_param *par 
{

	int ret = 0;

	struct adapter *padapter = rtw_netdev_priv(dev);

	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);

	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;

	int ie_len;



	if (check_fwstate(pmlmepriv, WIFI_AP_STATE) != true)
@@ -1042,7 +1042,7 @@ static int rtw_set_wps_assoc_resp(struct net_device *dev, struct ieee_param *par 
{

	int ret = 0;

	struct adapter *padapter = rtw_netdev_priv(dev);

	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);

	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;

	int ie_len;



	if (check_fwstate(pmlmepriv, WIFI_AP_STATE) != true)
@@ -1069,9 +1069,9 @@ static int rtw_set_hidden_ssid(struct net_device *dev, struct ieee_param *param, 
{

	int ret = 0;

	struct adapter *adapter = rtw_netdev_priv(dev);

	struct mlme_priv *mlmepriv = &(adapter->mlmepriv);

	struct mlme_ext_priv *mlmeext = &(adapter->mlmeextpriv);

	struct mlme_ext_info *mlmeinfo = &(mlmeext->mlmext_info);

	struct mlme_priv *mlmepriv = &adapter->mlmepriv;

	struct mlme_ext_priv *mlmeext = &adapter->mlmeextpriv;

	struct mlme_ext_info *mlmeinfo = &mlmeext->mlmext_info;

	int ie_len;

	u8 *ssid_ie;

	char ssid[NDIS_802_11_LENGTH_SSID + 1];
@@ -1108,7 +1108,7 @@ static int rtw_set_hidden_ssid(struct net_device *dev, struct ieee_param *param, 
static int rtw_ioctl_acl_remove_sta(struct net_device *dev, struct ieee_param *param, int len)

{

	struct adapter *padapter = rtw_netdev_priv(dev);

	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);

	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;



	if (check_fwstate(pmlmepriv, WIFI_AP_STATE) != true)

		return -EINVAL;
@@ -1126,7 +1126,7 @@ static int rtw_ioctl_acl_remove_sta(struct net_device *dev, struct ieee_param *p 
static int rtw_ioctl_acl_add_sta(struct net_device *dev, struct ieee_param *param, int len)

{

	struct adapter *padapter = rtw_netdev_priv(dev);

	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);

	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;



	if (check_fwstate(pmlmepriv, WIFI_AP_STATE) != true)

		return -EINVAL;
@@ -1144,7 +1144,7 @@ static int rtw_ioctl_set_macaddr_acl(struct net_device *dev, struct ieee_param * 
{

	int ret = 0;

	struct adapter *padapter = rtw_netdev_priv(dev);

	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);

	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;



	if (check_fwstate(pmlmepriv, WIFI_AP_STATE) != true)

		return -EINVAL;