Commit 7363805b authored Dec 08, 2021 by Oded Gabbay

habanalabs: remove in_debug check in device open



The driver supports only a single user anyway, so there is no point
in checking whether we are in_debug state when a user tries to open
the device, because if we are in_debug, it means a user is already
using the device.

Signed-off-by: Oded Gabbay <ogabbay@kernel.org>

parent 7c623ef7

drivers/misc/habanalabs/common/habanalabs.h

+3 −2

Original line number	Diff line number	Diff line
		@@ -2561,8 +2561,9 @@ struct last_error_session_info {
		* @init_done: is the initialization of the device done.
		* @device_cpu_disabled: is the device CPU disabled (due to timeouts)
		* @dma_mask: the dma mask that was set for this device
		* @in_debug: is device under debug. This, together with fpriv_list, enforces
		* that only a single user is configuring the debug infrastructure.
		* @in_debug: whether the device is in a state where the profiling/tracing infrastructure
		* can be used. This indication is needed because in some ASICs we need to do
		* specific operations to enable that infrastructure.
		* @power9_64bit_dma_enable: true to enable 64-bit DMA mask support. Relevant
		* only to POWER9 machines.
		* @cdev_sysfs_created: were char devices and sysfs nodes created.

drivers/misc/habanalabs/common/habanalabs_drv.c

+0 −8

Original line number	Diff line number	Diff line
		@@ -153,14 +153,6 @@ int hl_device_open(struct inode inode, struct file filp)
		goto out_err;
		}

		if (hdev->in_debug) {
		dev_err_ratelimited(hdev->dev,
		"Can't open %s because it is being debugged by another user\n",
		dev_name(hdev->dev));
		rc = -EPERM;
		goto out_err;
		}

		if (hdev->is_compute_ctx_active) {
		dev_dbg_ratelimited(hdev->dev,
		"Can't open %s because another user is working on it\n",