Commit 73a370cf authored by Wolfram Sang's avatar Wolfram Sang Committed by Wolfram Sang
Browse files

i2c: imx: : use proper DMAENGINE API for termination 



dmaengine_terminate_all() is deprecated in favor of explicitly saying if
it should be sync or async. Here, we want dmaengine_terminate_sync()
because there is no other synchronization code in the driver to handle
an async case.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 73c76332

drivers/i2c/busses/i2c-imx.c

+3 −3
Original line number Diff line number Diff line
@@ -423,7 +423,7 @@ static int i2c_imx_dma_xfer(struct imx_i2c_struct *i2c_imx, 
	return 0;



err_submit:

	dmaengine_terminate_all(dma->chan_using);

	dmaengine_terminate_sync(dma->chan_using);

err_desc:

	dma_unmap_single(chan_dev, dma->dma_buf,

			dma->dma_len, dma->dma_data_dir);
@@ -894,7 +894,7 @@ static int i2c_imx_dma_write(struct imx_i2c_struct *i2c_imx, 
				&i2c_imx->dma->cmd_complete,

				msecs_to_jiffies(DMA_TIMEOUT));

	if (time_left == 0) {

		dmaengine_terminate_all(dma->chan_using);

		dmaengine_terminate_sync(dma->chan_using);

		return -ETIMEDOUT;

	}
@@ -949,7 +949,7 @@ static int i2c_imx_dma_read(struct imx_i2c_struct *i2c_imx, 
				&i2c_imx->dma->cmd_complete,

				msecs_to_jiffies(DMA_TIMEOUT));

	if (time_left == 0) {

		dmaengine_terminate_all(dma->chan_using);

		dmaengine_terminate_sync(dma->chan_using);

		return -ETIMEDOUT;

	}