Commit 73b1da69 authored by Michael Strauss's avatar Michael Strauss Committed by Alex Deucher
Browse files

drm/amd/display: Check for invalid input params when building scaling params 



[WHY]
Function to calculate scaling ratios can be called with invalid plane
src/dest, causing a divide by zero.

[HOW]
Fail building scaling params if plane state src/dest rects are
unpopulated

Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Reviewed-by: default avatarCharlene Liu <Charlene.Liu@amd.com>
Acked-by: default avatarTom Chung <chiahsuan.chung@amd.com>
Signed-off-by: default avatarMichael Strauss <michael.strauss@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 176cd438

drivers/gpu/drm/amd/display/dc/core/dc_resource.c

+9 −0
Original line number Diff line number Diff line
@@ -1076,6 +1076,15 @@ bool resource_build_scaling_params(struct pipe_ctx *pipe_ctx) 
	bool res = false;

	DC_LOGGER_INIT(pipe_ctx->stream->ctx->logger);



	/* Invalid input */

	if (!plane_state->dst_rect.width ||

			!plane_state->dst_rect.height ||

			!plane_state->src_rect.width ||

			!plane_state->src_rect.height) {

		ASSERT(0);

		return false;

	}



	pipe_ctx->plane_res.scl_data.format = convert_pixel_format_to_dalsurface(

			pipe_ctx->plane_state->format);