Commit 741af75d authored by Johannes Thumshirn's avatar Johannes Thumshirn Committed by Jens Axboe
Browse files

fs: buffer: use __bio_add_page to add single page to bio 



The buffer_head submission code uses bio_add_page() to add a page to a
newly created bio. bio_add_page() can fail, but the return value is never
checked.

Use __bio_add_page() as adding a single page to a newly created bio is
guaranteed to succeed.

This brings us a step closer to marking bio_add_page() as __must_check.

Reviewed-by: default avatarGou Hao <gouhao@uniontech.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Link: https://lore.kernel.org/r/84ff2dcbe81b258a73ad900adb5266e208b61a4d.1685532726.git.johannes.thumshirn@wdc.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent fc8ac3e5

fs/buffer.c

+1 −2
Original line number Diff line number Diff line
@@ -2760,8 +2760,7 @@ static void submit_bh_wbc(blk_opf_t opf, struct buffer_head *bh, 


	bio->bi_iter.bi_sector = bh->b_blocknr * (bh->b_size >> 9);



	bio_add_page(bio, bh->b_page, bh->b_size, bh_offset(bh));

	BUG_ON(bio->bi_iter.bi_size != bh->b_size);

	__bio_add_page(bio, bh->b_page, bh->b_size, bh_offset(bh));



	bio->bi_end_io = end_bio_bh_io_sync;

	bio->bi_private = bh;