Commit 759411a0 authored by John B. Wyatt IV's avatar John B. Wyatt IV Committed by Greg Kroah-Hartman
Browse files

staging: wlan-ng: Fix third argument going over 80 characters 



Create a new 'status' variable to store the value of a long argument
that goes over 80 characters. The status variable is also used for
an if check. Replacing that long statement in both places makes the
code much easier to read.

Note: the status variable is assigned after a needed byte order
conversion for usbin->rxfrm.desc.status, which uses a reference.

Issue reported by checkpatch.

Suggested-by: default avatarStefano Brivio <sbrivio@redhat.com>
Signed-off-by: default avatarJohn B. Wyatt IV <jbwyatt4@gmail.com>
Reviewed-by: default avatarStefano Brivio <sbrivio@redhat.com>
Link: https://lore.kernel.org/r/20200321225808.2494564-1-jbwyatt4@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1c31a130

drivers/staging/wlan-ng/hfa384x_usb.c

+5 −2
Original line number Diff line number Diff line
@@ -3254,13 +3254,16 @@ static void hfa384x_usbin_rx(struct wlandevice *wlandev, struct sk_buff *skb) 
	struct p80211_rxmeta *rxmeta;

	u16 data_len;

	u16 fc;

	u16 status;



	/* Byte order convert once up front. */

	le16_to_cpus(&usbin->rxfrm.desc.status);

	le32_to_cpus(&usbin->rxfrm.desc.time);



	/* Now handle frame based on port# */

	switch (HFA384x_RXSTATUS_MACPORT_GET(usbin->rxfrm.desc.status)) {

	status = HFA384x_RXSTATUS_MACPORT_GET(usbin->rxfrm.desc.status);



	switch (status) {

	case 0:

		fc = le16_to_cpu(usbin->rxfrm.desc.frame_control);
@@ -3319,7 +3322,7 @@ static void hfa384x_usbin_rx(struct wlandevice *wlandev, struct sk_buff *skb) 
	default:

		netdev_warn(hw->wlandev->netdev,

			    "Received frame on unsupported port=%d\n",

			    HFA384x_RXSTATUS_MACPORT_GET(usbin->rxfrm.desc.status));

			    status);

		break;

	}

}