Unverified Commit 7872d423 authored by Yang Yingliang's avatar Yang Yingliang Committed by Xu Yilun
Browse files

fpga: zynq: Switch to use dev_err_probe() helper 



In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Acked-by: default avatarXu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/20220926141729.2292311-1-yangyingliang@huawei.com


Signed-off-by: default avatarXu Yilun <yilun.xu@intel.com>
parent 9abf2313

drivers/fpga/zynq-fpga.c

+3 −5
Original line number Diff line number Diff line
@@ -582,11 +582,9 @@ static int zynq_fpga_probe(struct platform_device *pdev) 
		return priv->irq;



	priv->clk = devm_clk_get(dev, "ref_clk");

	if (IS_ERR(priv->clk)) {

		if (PTR_ERR(priv->clk) != -EPROBE_DEFER)

			dev_err(dev, "input clock not found\n");

		return PTR_ERR(priv->clk);

	}

	if (IS_ERR(priv->clk))

		return dev_err_probe(dev, PTR_ERR(priv->clk),

				     "input clock not found\n");



	err = clk_prepare_enable(priv->clk);

	if (err) {