Commit 78ed9354 authored by Guoqing Jiang's avatar Guoqing Jiang Committed by Theodore Ts'o
Browse files

ext4: remove redundant checking in ext4_ioctl_checkpoint 



It is already checked after comment "check for invalid bits set",
so let's remove this one.

Signed-off-by: default avatarGuoqing Jiang <guoqing.jiang@linux.dev>
Link: https://lore.kernel.org/r/20220918115219.12407-1-guoqing.jiang@linux.dev


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent dfff66f3

fs/ext4/ioctl.c

+0 −3
Original line number Diff line number Diff line
@@ -1063,9 +1063,6 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg) 
	if (!EXT4_SB(sb)->s_journal)

		return -ENODEV;



	if (flags & ~EXT4_IOC_CHECKPOINT_FLAG_VALID)

		return -EINVAL;



	if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) &&

	    !bdev_max_discard_sectors(EXT4_SB(sb)->s_journal->j_dev))

		return -EOPNOTSUPP;