Commit 79e30b88 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Call scsi_done() directly 

Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-66-bvanassche@acm.org


Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 2d1609af

drivers/scsi/qla2xxx/qla_os.c

+4 −4
Original line number Diff line number Diff line
@@ -737,7 +737,7 @@ void qla2x00_sp_compl(srb_t *sp, int res) 
	sp->free(sp);

	cmd->result = res;

	CMD_SP(cmd) = NULL;

	cmd->scsi_done(cmd);

	scsi_done(cmd);

	if (comp)

		complete(comp);

}
@@ -828,7 +828,7 @@ void qla2xxx_qpair_sp_compl(srb_t *sp, int res) 
	sp->free(sp);

	cmd->result = res;

	CMD_SP(cmd) = NULL;

	cmd->scsi_done(cmd);

	scsi_done(cmd);

	if (comp)

		complete(comp);

}
@@ -950,7 +950,7 @@ qla2xxx_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd) 
	return SCSI_MLQUEUE_TARGET_BUSY;



qc24_fail_command:

	cmd->scsi_done(cmd);

	scsi_done(cmd);



	return 0;

}
@@ -1038,7 +1038,7 @@ qla2xxx_mqueuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd, 
	return SCSI_MLQUEUE_TARGET_BUSY;



qc24_fail_command:

	cmd->scsi_done(cmd);

	scsi_done(cmd);



	return 0;

}