Commit 7ad67a20 authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Saeed Mahameed
Browse files

net/mlx5: Don't rely on interface state bit 



The check of MLX5_INTERFACE_STATE_UP is completely useless, because
the FW tracer cleanup is called on every change of the interface
and it ensures that notifier is disabled together with canceling
all the pending works.

Reviewed-by: default avatarMoshe Shemesh <moshe@nvidia.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 7e615b99

drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c

+1 −2
Original line number Diff line number Diff line
@@ -1126,7 +1126,6 @@ static int fw_tracer_event(struct notifier_block *nb, unsigned long action, void 


	switch (eqe->sub_type) {

	case MLX5_TRACER_SUBTYPE_OWNERSHIP_CHANGE:

		if (test_bit(MLX5_INTERFACE_STATE_UP, &dev->intf_state))

		queue_work(tracer->work_queue, &tracer->ownership_change_work);

		break;

	case MLX5_TRACER_SUBTYPE_TRACES_AVAILABLE: