Commit 7b49f61a authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Helge Deller
Browse files

fbdev: sm501fb: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 4ba34066

drivers/video/fbdev/sm501fb.c

+2 −4
Original line number Diff line number Diff line
@@ -2045,7 +2045,7 @@ static int sm501fb_probe(struct platform_device *pdev) 
/*

 *  Cleanup

 */

static int sm501fb_remove(struct platform_device *pdev)

static void sm501fb_remove(struct platform_device *pdev)

{

	struct sm501fb_info *info = platform_get_drvdata(pdev);

	struct fb_info	   *fbinfo_crt = info->fb[0];
@@ -2064,8 +2064,6 @@ static int sm501fb_remove(struct platform_device *pdev) 


	framebuffer_release(fbinfo_pnl);

	framebuffer_release(fbinfo_crt);



	return 0;

}



#ifdef CONFIG_PM
@@ -2209,7 +2207,7 @@ static int sm501fb_resume(struct platform_device *pdev) 


static struct platform_driver sm501fb_driver = {

	.probe		= sm501fb_probe,

	.remove		= sm501fb_remove,

	.remove_new	= sm501fb_remove,

	.suspend	= sm501fb_suspend,

	.resume		= sm501fb_resume,

	.driver		= {