Commit 7bc195c7 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: ppa: Call scsi_done() directly 

Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-62-bvanassche@acm.org


Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent f13cc234

drivers/scsi/ppa.c

+1 −2
Original line number Diff line number Diff line
@@ -665,7 +665,7 @@ static void ppa_interrupt(struct work_struct *work) 


	dev->cur_cmd = NULL;



	cmd->scsi_done(cmd);

	scsi_done(cmd);

}



static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd)
@@ -798,7 +798,6 @@ static int ppa_queuecommand_lck(struct scsi_cmnd *cmd, 
	dev->failed = 0;

	dev->jstart = jiffies;

	dev->cur_cmd = cmd;

	cmd->scsi_done = done;

	cmd->result = DID_ERROR << 16;	/* default return code */

	cmd->SCp.phase = 0;	/* bus free */