Commit 7cf5307c authored by Cai Huoqing's avatar Cai Huoqing Committed by Jonathan Cameron
Browse files

iio: dac: lpc18xx_dac: Make use of the helper function dev_err_probe() 



When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210928013902.1341-2-caihuoqing@baidu.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent f80d6061

drivers/iio/dac/lpc18xx_dac.c

+6 −8
Original line number Diff line number Diff line
@@ -121,16 +121,14 @@ static int lpc18xx_dac_probe(struct platform_device *pdev) 
		return PTR_ERR(dac->base);



	dac->clk = devm_clk_get(&pdev->dev, NULL);

	if (IS_ERR(dac->clk)) {

		dev_err(&pdev->dev, "error getting clock\n");

		return PTR_ERR(dac->clk);

	}

	if (IS_ERR(dac->clk))

		return dev_err_probe(&pdev->dev, PTR_ERR(dac->clk),

				     "error getting clock\n");



	dac->vref = devm_regulator_get(&pdev->dev, "vref");

	if (IS_ERR(dac->vref)) {

		dev_err(&pdev->dev, "error getting regulator\n");

		return PTR_ERR(dac->vref);

	}

	if (IS_ERR(dac->vref))

		return dev_err_probe(&pdev->dev, PTR_ERR(dac->vref),

				     "error getting regulator\n");



	indio_dev->name = dev_name(&pdev->dev);

	indio_dev->info = &lpc18xx_dac_info;