Commit 7d4a8be0 authored by Alistair Popple's avatar Alistair Popple Committed by Andrew Morton
Browse files

mm/mmu_notifier: remove unused mmu_notifier_range_update_to_read_only export 

mmu_notifier_range_update_to_read_only() was originally introduced in
commit c6d23413 ("mm/mmu_notifier:
mmu_notifier_range_update_to_read_only() helper") as an optimisation for
device drivers that know a range has only been mapped read-only.  However
there are no users of this feature so remove it.  As it is the only user
of the struct mmu_notifier_range.vma field remove that also.

Link: https://lkml.kernel.org/r/20230110025722.600912-1-apopple@nvidia.com


Signed-off-by: default avatarAlistair Popple <apopple@nvidia.com>
Acked-by: default avatarMike Rapoport (IBM) <rppt@kernel.org>
Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarMike Kravetz <mike.kravetz@oracle.com>
Cc: Ira Weiny <ira.weiny@intel.com>
Cc: Jerome Glisse <jglisse@redhat.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Ralph Campbell <rcampbell@nvidia.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 9e552271

fs/proc/task_mmu.c

+1 −1
Original line number Diff line number Diff line
@@ -1306,7 +1306,7 @@ static ssize_t clear_refs_write(struct file *file, const char __user *buf, 


			inc_tlb_flush_pending(mm);

			mmu_notifier_range_init(&range, MMU_NOTIFY_SOFT_DIRTY,

						0, NULL, mm, 0, -1UL);

						0, mm, 0, -1UL);

			mmu_notifier_invalidate_range_start(&range);

		}

		walk_page_range(mm, 0, -1, &clear_refs_walk_ops, &cp);

include/linux/mmu_notifier.h

+5 −8
Original line number Diff line number Diff line
@@ -269,7 +269,6 @@ extern struct lockdep_map __mmu_notifier_invalidate_range_start_map; 
#endif



struct mmu_notifier_range {

	struct vm_area_struct *vma;

	struct mm_struct *mm;

	unsigned long start;

	unsigned long end;
@@ -514,12 +513,10 @@ static inline void mmu_notifier_subscriptions_destroy(struct mm_struct *mm) 
static inline void mmu_notifier_range_init(struct mmu_notifier_range *range,

					   enum mmu_notifier_event event,

					   unsigned flags,

					   struct vm_area_struct *vma,

					   struct mm_struct *mm,

					   unsigned long start,

					   unsigned long end)

{

	range->vma = vma;

	range->event = event;

	range->mm = mm;

	range->start = start;
@@ -530,10 +527,10 @@ static inline void mmu_notifier_range_init(struct mmu_notifier_range *range, 
static inline void mmu_notifier_range_init_owner(

			struct mmu_notifier_range *range,

			enum mmu_notifier_event event, unsigned int flags,

			struct vm_area_struct *vma, struct mm_struct *mm,

			unsigned long start, unsigned long end, void *owner)

			struct mm_struct *mm, unsigned long start,

			unsigned long end, void *owner)

{

	mmu_notifier_range_init(range, event, flags, vma, mm, start, end);

	mmu_notifier_range_init(range, event, flags, mm, start, end);

	range->owner = owner;

}
@@ -659,9 +656,9 @@ static inline void _mmu_notifier_range_init(struct mmu_notifier_range *range, 
	range->end = end;

}



#define mmu_notifier_range_init(range,event,flags,vma,mm,start,end)  \

#define mmu_notifier_range_init(range,event,flags,mm,start,end)  \

	_mmu_notifier_range_init(range, start, end)

#define mmu_notifier_range_init_owner(range, event, flags, vma, mm, start, \

#define mmu_notifier_range_init_owner(range, event, flags, mm, start, \

					end, owner) \

	_mmu_notifier_range_init(range, start, end)

kernel/events/uprobes.c

+1 −1
Original line number Diff line number Diff line
@@ -161,7 +161,7 @@ static int __replace_page(struct vm_area_struct *vma, unsigned long addr, 
	int err;

	struct mmu_notifier_range range;



	mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, vma, mm, addr,

	mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, mm, addr,

				addr + PAGE_SIZE);



	if (new_page) {

mm/huge_memory.c

+2 −2
Original line number Diff line number Diff line
@@ -2020,7 +2020,7 @@ void __split_huge_pud(struct vm_area_struct *vma, pud_t *pud, 
	spinlock_t *ptl;

	struct mmu_notifier_range range;



	mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, vma, vma->vm_mm,

	mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, vma->vm_mm,

				address & HPAGE_PUD_MASK,

				(address & HPAGE_PUD_MASK) + HPAGE_PUD_SIZE);

	mmu_notifier_invalidate_range_start(&range);
@@ -2282,7 +2282,7 @@ void __split_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd, 
	spinlock_t *ptl;

	struct mmu_notifier_range range;



	mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, vma, vma->vm_mm,

	mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, vma->vm_mm,

				address & HPAGE_PMD_MASK,

				(address & HPAGE_PMD_MASK) + HPAGE_PMD_SIZE);

	mmu_notifier_invalidate_range_start(&range);

mm/hugetlb.c

+6 −6
Original line number Diff line number Diff line
@@ -4966,7 +4966,7 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src, 
	int ret = 0;



	if (cow) {

		mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, src_vma, src,

		mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, src,

					src_vma->vm_start,

					src_vma->vm_end);

		mmu_notifier_invalidate_range_start(&range);
@@ -5177,7 +5177,7 @@ int move_hugetlb_page_tables(struct vm_area_struct *vma, 
	struct mmu_notifier_range range;

	bool shared_pmd = false;



	mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, vma, mm, old_addr,

	mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, mm, old_addr,

				old_end);

	adjust_range_if_pmd_sharing_possible(vma, &range.start, &range.end);

	/*
@@ -5391,7 +5391,7 @@ void unmap_hugepage_range(struct vm_area_struct *vma, unsigned long start, 
	struct mmu_notifier_range range;

	struct mmu_gather tlb;



	mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, vma, vma->vm_mm,

	mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, vma->vm_mm,

				start, end);

	adjust_range_if_pmd_sharing_possible(vma, &range.start, &range.end);

	mmu_notifier_invalidate_range_start(&range);
@@ -5597,7 +5597,7 @@ static vm_fault_t hugetlb_wp(struct mm_struct *mm, struct vm_area_struct *vma, 
			    pages_per_huge_page(h));

	__SetPageUptodate(new_page);



	mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, vma, mm, haddr,

	mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, mm, haddr,

				haddr + huge_page_size(h));

	mmu_notifier_invalidate_range_start(&range);
@@ -6637,7 +6637,7 @@ long hugetlb_change_protection(struct vm_area_struct *vma, 
	 * range if PMD sharing is possible.

	 */

	mmu_notifier_range_init(&range, MMU_NOTIFY_PROTECTION_VMA,

				0, vma, mm, start, end);

				0, mm, start, end);

	adjust_range_if_pmd_sharing_possible(vma, &range.start, &range.end);



	BUG_ON(address >= end);
@@ -7368,7 +7368,7 @@ static void hugetlb_unshare_pmds(struct vm_area_struct *vma, 
	 * No need to call adjust_range_if_pmd_sharing_possible(), because

	 * we have already done the PUD_SIZE alignment.

	 */

	mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, vma, mm,

	mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, mm,

				start, end);

	mmu_notifier_invalidate_range_start(&range);

	hugetlb_vma_lock_write(vma);