Commit 7df2af0b authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

rbd: use bvec_set_page to initialize the copy up bvec 



Use the bvec_set_page helper to initialize the copy up bvec.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarIlya Dryomov <idryomov@gmail.com>
Link: https://lore.kernel.org/r/20230203150634.3199647-9-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 4bee16da

drivers/block/rbd.c

+3 −4
Original line number Diff line number Diff line
@@ -3068,13 +3068,12 @@ static int setup_copyup_bvecs(struct rbd_obj_request *obj_req, u64 obj_overlap) 


	for (i = 0; i < obj_req->copyup_bvec_count; i++) {

		unsigned int len = min(obj_overlap, (u64)PAGE_SIZE);

		struct page *page = alloc_page(GFP_NOIO);



		obj_req->copyup_bvecs[i].bv_page = alloc_page(GFP_NOIO);

		if (!obj_req->copyup_bvecs[i].bv_page)

		if (!page)

			return -ENOMEM;



		obj_req->copyup_bvecs[i].bv_offset = 0;

		obj_req->copyup_bvecs[i].bv_len = len;

		bvec_set_page(&obj_req->copyup_bvecs[i], page, len, 0);

		obj_overlap -= len;

	}