Commit 7e8da605 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Pavel Machek
Browse files

leds: pwm: Simplify with dev_err_probe() 



Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: default avatarPavel Machek <pavel@ucw.cz>
parent 47eaa8ba

drivers/leds/leds-pwm.c

+4 −7
Original line number Diff line number Diff line
@@ -78,13 +78,10 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, 
		led_data->pwm = devm_fwnode_pwm_get(dev, fwnode, NULL);

	else

		led_data->pwm = devm_pwm_get(dev, led->name);

	if (IS_ERR(led_data->pwm)) {

		ret = PTR_ERR(led_data->pwm);

		if (ret != -EPROBE_DEFER)

			dev_err(dev, "unable to request PWM for %s: %d\n",

				led->name, ret);

		return ret;

	}

	if (IS_ERR(led_data->pwm))

		return dev_err_probe(dev, PTR_ERR(led_data->pwm),

				     "unable to request PWM for %s\n",

				     led->name);



	led_data->cdev.brightness_set_blocking = led_pwm_set;