Commit 7f201acf authored by Lee Jones's avatar Lee Jones Committed by Greg Kroah-Hartman
Browse files

staging: r8192U_core: Remove unused variable 'ret' and demote kernel-doc abuse 



Fixes the following W=1 kernel build warning(s):

 drivers/staging/rtl8192u/r8192U_core.c: In function ‘rtl8192_hard_data_xmit’:
 drivers/staging/rtl8192u/r8192U_core.c:905:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andrea Merello <andrea.merello@gmail.com>
Cc: Jerry chuang <wlanfae@realtek.com>
Cc: linux-staging@lists.linux.dev
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20210414181129.1628598-2-lee.jones@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6efb943b

drivers/staging/rtl8192u/r8192U_core.c

+2 −5
Original line number Diff line number Diff line
@@ -902,7 +902,6 @@ static void rtl8192_hard_data_xmit(struct sk_buff *skb, struct net_device *dev, 
				   int rate)

{

	struct r8192_priv *priv = (struct r8192_priv *)ieee80211_priv(dev);

	int ret;

	unsigned long flags;

	struct cb_desc *tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);

	u8 queue_index = tcb_desc->queue_index;
@@ -915,7 +914,7 @@ static void rtl8192_hard_data_xmit(struct sk_buff *skb, struct net_device *dev, 
	*(struct net_device **)(skb->cb) = dev;

	tcb_desc->bTxEnableFwCalcDur = 1;

	skb_push(skb, priv->ieee80211->tx_headroom);

	ret = rtl8192_tx(dev, skb);

	rtl8192_tx(dev, skb);



	spin_unlock_irqrestore(&priv->tx_lock, flags);

}
@@ -2972,12 +2971,10 @@ static RESET_TYPE RxCheckStuck(struct net_device *dev) 
	return RESET_TYPE_NORESET;

}



/**

/*

 * This function is called by Checkforhang to check whether we should

 * ask OS to reset driver

 *

 * \param pAdapter	The adapter context for this miniport

 *

 * Note:NIC with USB interface sholud not call this function because we

 * cannot scan descriptor to judge whether there is tx stuck.

 * Note: This function may be required to be rewrite for Vista OS.