Commit 7fcbf5fd authored Jul 03, 2013 by Jingoo Han Committed by Linus Torvalds Jul 03, 2013

rtc: rtc-coh901331: remove unnecessary platform_set_drvdata()



The driver core clears the driver data to NULL after device_release or
on probe failure, since commit 0998d063 ("device-core: Ensure drvdata
= NULL when no driver is bound").  Thus, it is not needed to manually
clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent a8e23d7b

drivers/rtc/rtc-coh901331.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -154,10 +154,8 @@ static int __exit coh901331_remove(struct platform_device *pdev)
		{
		struct coh901331_port *rtap = dev_get_drvdata(&pdev->dev);

		if (rtap) {
		if (rtap)
		clk_unprepare(rtap->clk);
		platform_set_drvdata(pdev, NULL);
		}

		return 0;
		}
		@@ -220,7 +218,6 @@ static int __init coh901331_probe(struct platform_device *pdev)
		return 0;

		out_no_rtc:
		platform_set_drvdata(pdev, NULL);
		clk_unprepare(rtap->clk);
		return ret;
		}