Commit 811eb344 authored by Xiangyang Zhang's avatar Xiangyang Zhang Committed by Greg Kroah-Hartman
Browse files

staging: qlge: unmap dma when lock failed 



DMA not unmapped when lock failed, this patch fixed it.

Signed-off-by: default avatarXiangyang Zhang <xyz.sun.ok@gmail.com>
Fixes: 4322c5be ("qlge: Expand coverage of hw lock for config register.")
Link: https://lore.kernel.org/r/20200517054638.10764-1-xyz.sun.ok@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2493c61e

drivers/staging/qlge/qlge_main.c

+2 −1
Original line number Diff line number Diff line
@@ -227,7 +227,7 @@ int ql_write_cfg(struct ql_adapter *qdev, void *ptr, int size, u32 bit, 


	status = ql_sem_spinlock(qdev, SEM_ICB_MASK);

	if (status)

		return status;

		goto lock_failed;



	status = ql_wait_cfg(qdev, bit);

	if (status) {
@@ -249,6 +249,7 @@ int ql_write_cfg(struct ql_adapter *qdev, void *ptr, int size, u32 bit, 
	status = ql_wait_cfg(qdev, bit);

exit:

	ql_sem_unlock(qdev, SEM_ICB_MASK);	/* does flush too */

lock_failed:

	dma_unmap_single(&qdev->pdev->dev, map, size, direction);

	return status;

}