Commit 819a47d2 authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Will Deacon
Browse files

arm64: clean up tools Makefile 



Remove unused gen-y.

Remove redundant $(shell ...) because 'mkdir' is done in cmd_gen_cpucaps.

Replace $(filter-out $(PHONY), $^) with the $(real-prereqs) shorthand.

The '&&' in cmd_gen_cpucaps should be replaced with ';' because it is
run under 'set -e' environment.

Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
Link: https://lore.kernel.org/r/20220227085232.206529-1-masahiroy@kernel.org


Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent ee94b5a0

arch/arm64/tools/Makefile

+3 −7
Original line number Original line Diff line number Diff line
@@ -5,18 +5,14 @@ kapi := $(gen)/asm 




kapi-hdrs-y := $(kapi)/cpucaps.h

kapi-hdrs-y := $(kapi)/cpucaps.h





targets += $(addprefix ../../../,$(gen-y) $(kapi-hdrs-y))

targets += $(addprefix ../../../, $(kapi-hdrs-y))





PHONY += kapi

PHONY += kapi





kapi:   $(kapi-hdrs-y) $(gen-y)

kapi:   $(kapi-hdrs-y)



# Create output directory if not already present

_dummy := $(shell [ -d '$(kapi)' ] || mkdir -p '$(kapi)')





quiet_cmd_gen_cpucaps = GEN     $@

quiet_cmd_gen_cpucaps = GEN     $@

      cmd_gen_cpucaps = mkdir -p $(dir $@) && \

      cmd_gen_cpucaps = mkdir -p $(dir $@); $(AWK) -f $(real-prereqs) > $@

                     $(AWK) -f $(filter-out $(PHONY),$^) > $@





$(kapi)/cpucaps.h: $(src)/gen-cpucaps.awk $(src)/cpucaps FORCE

$(kapi)/cpucaps.h: $(src)/gen-cpucaps.awk $(src)/cpucaps FORCE

	$(call if_changed,gen_cpucaps)
 
	$(call if_changed,gen_cpucaps)