Commit 82483dfe authored Feb 22, 2023 by Kemeng Shi Committed by Theodore Ts'o Mar 23, 2023

ext4: remove unused group parameter in ext4_block_bitmap_csum_verify



Remove unused group parameter in ext4_block_bitmap_csum_verify.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230221203027.2359920-4-shikemeng@huaweicloud.com


Signed-off-by: Theodore Ts'o <tytso@mit.edu>

parent 4fd873c8

fs/ext4/balloc.c

+1 −2

Original line number	Original line	Diff line number	Diff line
	@@ -385,8 +385,7 @@ static int ext4_validate_block_bitmap(struct super_block *sb,
	ext4_lock_group(sb, block_group);		ext4_lock_group(sb, block_group);
	if (buffer_verified(bh))		if (buffer_verified(bh))
	goto verified;		goto verified;
	if (unlikely(!ext4_block_bitmap_csum_verify(sb, block_group,		if (unlikely(!ext4_block_bitmap_csum_verify(sb, desc, bh) \|\|
	desc, bh) \|\|
	ext4_simulate_fail(sb, EXT4_SIM_BBITMAP_CRC))) {		ext4_simulate_fail(sb, EXT4_SIM_BBITMAP_CRC))) {
	ext4_unlock_group(sb, block_group);		ext4_unlock_group(sb, block_group);
	ext4_error(sb, "bg %u: bad block bitmap checksum", block_group);		ext4_error(sb, "bg %u: bad block bitmap checksum", block_group);

fs/ext4/bitmap.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -54,7 +54,7 @@ void ext4_inode_bitmap_csum_set(struct super_block *sb,
	gdp->bg_inode_bitmap_csum_hi = cpu_to_le16(csum >> 16);		gdp->bg_inode_bitmap_csum_hi = cpu_to_le16(csum >> 16);
	}		}

	int ext4_block_bitmap_csum_verify(struct super_block *sb, ext4_group_t group,		int ext4_block_bitmap_csum_verify(struct super_block *sb,
	struct ext4_group_desc *gdp,		struct ext4_group_desc *gdp,
	struct buffer_head *bh)		struct buffer_head *bh)
	{		{

fs/ext4/ext4.h

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -2685,7 +2685,7 @@ int ext4_inode_bitmap_csum_verify(struct super_block *sb,
	void ext4_block_bitmap_csum_set(struct super_block *sb, ext4_group_t group,		void ext4_block_bitmap_csum_set(struct super_block *sb, ext4_group_t group,
	struct ext4_group_desc *gdp,		struct ext4_group_desc *gdp,
	struct buffer_head *bh);		struct buffer_head *bh);
	int ext4_block_bitmap_csum_verify(struct super_block *sb, ext4_group_t group,		int ext4_block_bitmap_csum_verify(struct super_block *sb,
	struct ext4_group_desc *gdp,		struct ext4_group_desc *gdp,
	struct buffer_head *bh);		struct buffer_head *bh);