Commit 83a75e3f authored by Sandhya Bankar's avatar Sandhya Bankar Committed by Greg Kroah-Hartman
Browse files

Staging: lustre: Convert array index from the loop bound to the loop index. 



Convert array index from the loop bound to the loop index.

The structure cl_env_percpu[NR_CPUS] has been initializing for each possible
cpu (i.e 0 to i). During initialization if any error will occurred, the error
handling code should uninitialize cl_env_percpu upto i. But currently
unitialization is repeatedly done for the same cl_env_percpu[i] element.
This does not seems to be correct.

Used below semantic patch to identify this issue:

@@
expression e1,e2,ar;
@@
for(e1 = 0; e1 < e2; e1++) { <...
  ar[
- e2
+ e1
  ]
  ...> }

Signed-off-by: default avatarSandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7d700518

drivers/staging/lustre/lustre/obdclass/cl_object.c

+1 −1
Original line number Diff line number Diff line
@@ -1022,7 +1022,7 @@ static int cl_env_percpu_init(void) 
		 * thus we must uninitialize up to i, the rest are undefined.

		 */

		for (j = 0; j < i; j++) {

			cle = &cl_env_percpu[i];

			cle = &cl_env_percpu[j];

			lu_context_exit(&cle->ce_ses);

			lu_context_fini(&cle->ce_ses);

			lu_env_fini(&cle->ce_lu);