Commit 84536351 authored by James Smart's avatar James Smart Committed by Martin K. Petersen
Browse files

scsi: lpfc: Fix multiple NVMe remoteport registration calls for the same NPort ID 

When a target makes the mistake of registering a FC4 type with the fabric,
but then rejects a PRLI of that type, the lpfc driver incorrectly retries
the PRLI causing multiple registrations with the transport. The driver
needs to detect the reject reason data and stop any retry.

Rework the PRLI reject scenarios.

Link: https://lore.kernel.org/r/20220911221505.117655-6-jsmart2021@gmail.com


Co-developed-by: default avatarJustin Tee <justin.tee@broadcom.com>
Signed-off-by: default avatarJustin Tee <justin.tee@broadcom.com>
Signed-off-by: default avatarJames Smart <jsmart2021@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 0630a1f7

drivers/scsi/lpfc/lpfc_disc.h

+0 −1
Original line number Diff line number Diff line
@@ -187,7 +187,6 @@ struct lpfc_node_rrq { 
#define NLP_RNID_SND       0x00000400	/* sent RNID request for this entry */

#define NLP_ELS_SND_MASK   0x000007e0	/* sent ELS request for this entry */

#define NLP_NVMET_RECOV    0x00001000   /* NVMET auditing node for recovery. */

#define NLP_FCP_PRLI_RJT   0x00002000   /* Rport does not support FCP PRLI. */

#define NLP_UNREG_INP      0x00008000	/* UNREG_RPI cmd is in progress */

#define NLP_DROPPED        0x00010000	/* Init ref count has been dropped */

#define NLP_DELAY_TMO      0x00020000	/* delay timeout is running for node */

drivers/scsi/lpfc/lpfc_els.c

+36 −40
Original line number Diff line number Diff line
@@ -2200,10 +2200,6 @@ lpfc_issue_els_plogi(struct lpfc_vport *vport, uint32_t did, uint8_t retry) 
	if (!elsiocb)

		return 1;



	spin_lock_irq(&ndlp->lock);

	ndlp->nlp_flag &= ~NLP_FCP_PRLI_RJT;

	spin_unlock_irq(&ndlp->lock);



	pcmd = (uint8_t *)elsiocb->cmd_dmabuf->virt;



	/* For PLOGI request, remainder of payload is service parameters */
@@ -4676,47 +4672,52 @@ lpfc_els_retry(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, 
		}

		switch (stat.un.b.lsRjtRsnCode) {

		case LSRJT_UNABLE_TPC:

			/* The driver has a VALID PLOGI but the rport has

			 * rejected the PRLI - can't do it now.  Delay

			 * for 1 second and try again.

			 *

			 * However, if explanation is REQ_UNSUPPORTED there's

			 * no point to retry PRLI.

			/* Special case for PRLI LS_RJTs. Recall that lpfc

			 * uses a single routine to issue both PRLI FC4 types.

			 * If the PRLI is rejected because that FC4 type

			 * isn't really supported, don't retry and cause

			 * multiple transport registrations.  Otherwise, parse

			 * the reason code/reason code explanation and take the

			 * appropriate action.

			 */

			if ((cmd == ELS_CMD_PRLI || cmd == ELS_CMD_NVMEPRLI) &&

			    stat.un.b.lsRjtRsnCodeExp !=

			    LSEXP_REQ_UNSUPPORTED) {

				delay = 1000;

				maxretry = lpfc_max_els_tries + 1;

				retry = 1;

				break;

			}



			/* Legacy bug fix code for targets with PLOGI delays. */

			if (stat.un.b.lsRjtRsnCodeExp ==

			    LSEXP_CMD_IN_PROGRESS) {

			lpfc_printf_vlog(vport, KERN_INFO,

					 LOG_DISCOVERY | LOG_ELS | LOG_NODE,

					 "0153 ELS cmd x%x LS_RJT by x%x. "

					 "RsnCode x%x RsnCodeExp x%x\n",

					 cmd, did, stat.un.b.lsRjtRsnCode,

					 stat.un.b.lsRjtRsnCodeExp);



			switch (stat.un.b.lsRjtRsnCodeExp) {

			case LSEXP_CANT_GIVE_DATA:

			case LSEXP_CMD_IN_PROGRESS:

				if (cmd == ELS_CMD_PLOGI) {

					delay = 1000;

					maxretry = 48;

				}

				retry = 1;

				break;

			}

			if (stat.un.b.lsRjtRsnCodeExp ==

			    LSEXP_CANT_GIVE_DATA) {

				if (cmd == ELS_CMD_PLOGI) {

					delay = 1000;

					maxretry = 48;

				}

				retry = 1;

			case LSEXP_REQ_UNSUPPORTED:

			case LSEXP_NO_RSRC_ASSIGN:

				/* These explanation codes get no retry. */

				if (cmd == ELS_CMD_PRLI ||

				    cmd == ELS_CMD_NVMEPRLI)

					break;

			}

			if (cmd == ELS_CMD_PLOGI) {

				fallthrough;

			default:

				/* Limit the delay and retry action to a limited

				 * cmd set.  There are other ELS commands where

				 * a retry is not expected.

				 */

				if (cmd == ELS_CMD_PLOGI ||

				    cmd == ELS_CMD_PRLI ||

				    cmd == ELS_CMD_NVMEPRLI) {

					delay = 1000;

					maxretry = lpfc_max_els_tries + 1;

					retry = 1;

				}

				break;

			}



			if ((phba->sli3_options & LPFC_SLI3_NPIV_ENABLED) &&

			  (cmd == ELS_CMD_FDISC) &&

			  (stat.un.b.lsRjtRsnCodeExp == LSEXP_OUT_OF_RESOURCE)){
@@ -4797,14 +4798,9 @@ lpfc_els_retry(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, 
			 */

			if (stat.un.b.lsRjtRsnCodeExp ==

			    LSEXP_REQ_UNSUPPORTED) {

				if (cmd == ELS_CMD_PRLI) {

					spin_lock_irq(&ndlp->lock);

					ndlp->nlp_flag |= NLP_FCP_PRLI_RJT;

					spin_unlock_irq(&ndlp->lock);

					retry = 0;

				if (cmd == ELS_CMD_PRLI)

					goto out_retry;

			}

			}

			break;

		}

		break;

drivers/scsi/lpfc/lpfc_hw.h

+1 −0
Original line number Diff line number Diff line
@@ -703,6 +703,7 @@ struct ls_rjt { /* Structure is in Big Endian format */ 
#define LSEXP_OUT_OF_RESOURCE   0x29

#define LSEXP_CANT_GIVE_DATA    0x2A

#define LSEXP_REQ_UNSUPPORTED   0x2C

#define LSEXP_NO_RSRC_ASSIGN    0x52

			uint8_t vendorUnique;	/* FC Word 0, bit  0: 7 */

		} b;

	} un;