Commit 846d846d authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: remove unnecessary category check 



Remove the unnecessary category check in issue_action_BA. category is
initialised to 3 (WLAN_CATEGORY_BACK) and never updated.

The rtw_set_fixed_ie call gets a pointer to category but it doesn't update
the value.

Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220524090029.242584-2-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f551dc6e

drivers/staging/r8188eu/core/rtw_mlme_ext.c

+46 −48
Original line number Diff line number Diff line
@@ -5415,7 +5415,6 @@ void issue_action_BA(struct adapter *padapter, unsigned char *raddr, unsigned ch 
	pframe = rtw_set_fixed_ie(pframe, 1, &(category), &pattrib->pktlen);

	pframe = rtw_set_fixed_ie(pframe, 1, &(action), &pattrib->pktlen);



	if (category == 3) {

	switch (action) {

	case 0: /* ADDBA req */

		do {
@@ -5469,7 +5468,6 @@ void issue_action_BA(struct adapter *padapter, unsigned char *raddr, unsigned ch 
	default:

		break;

	}

	}



	pattrib->last_txcmdsz = pattrib->pktlen;