Commit 8499a245 authored by Kuniyuki Iwashima's avatar Kuniyuki Iwashima Committed by David S. Miller
Browse files

tcp: Fix a data-race around sysctl_tcp_nometrics_save. 



While reading sysctl_tcp_nometrics_save, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 706c6202

net/ipv4/tcp_metrics.c

+1 −1
Original line number Diff line number Diff line
@@ -329,7 +329,7 @@ void tcp_update_metrics(struct sock *sk) 
	int m;



	sk_dst_confirm(sk);

	if (net->ipv4.sysctl_tcp_nometrics_save || !dst)

	if (READ_ONCE(net->ipv4.sysctl_tcp_nometrics_save) || !dst)

		return;



	rcu_read_lock();