Commit 84c868a7 authored by Justin Tee's avatar Justin Tee Committed by Martin K. Petersen
Browse files

scsi: lpfc: Fix verbose logging for SCSI commands issued to SES devices 



For SES LUNs with scsi_device sector_size member set to zero, there is no
point to log an LBA.  When verbose FCP driver logging is enabled, sanity
check sector_size before calling scsi_get_lba() on a scsi_cmnd.

Signed-off-by: default avatarJustin Tee <justin.tee@broadcom.com>
Link: https://lore.kernel.org/r/20230417191558.83100-2-justintee8345@gmail.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent ac9a7868

drivers/scsi/lpfc/lpfc_scsi.c

+2 −1
Original line number Diff line number Diff line
@@ -4273,7 +4273,8 @@ lpfc_fcp_io_cmd_wqe_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pwqeIn, 
				 "x%x SNS x%x x%x LBA x%llx Data: x%x x%x\n",

				 cmd->device->id, cmd->device->lun, cmd,

				 cmd->result, *lp, *(lp + 3),

				 (u64)scsi_get_lba(cmd),

				 (cmd->device->sector_size) ?

				 (u64)scsi_get_lba(cmd) : 0,

				 cmd->retries, scsi_get_resid(cmd));

	}