Commit 84efd207 authored by David Kershner's avatar David Kershner Committed by Greg Kroah-Hartman
Browse files

staging: unisys: visorbus: move toolaction functions to remove prototypes 



The toolchain functions show and store needed to be moved so the prototypes
were no longer needed.

Reported-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarDavid Kershner <david.kershner@unisys.com>
Reviewed-by: default avatarTim Sell <Timothy.Sell@unisys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5f251395

drivers/staging/unisys/visorbus/visorchipset.c

+29 −35
Original line number Original line Diff line number Diff line
@@ -185,10 +185,37 @@ static dev_t major_dev = -1; /*< indicates major num for device */ 




/* prototypes for attributes */

/* prototypes for attributes */

static ssize_t toolaction_show(struct device *dev,

static ssize_t toolaction_show(struct device *dev,

			       struct device_attribute *attr, char *buf);

			       struct device_attribute *attr,

			       char *buf)

{

	u8 tool_action = 0;



	visorchannel_read(controlvm_channel,

			  offsetof(struct spar_controlvm_channel_protocol,

				   tool_action), &tool_action, sizeof(u8));

	return scnprintf(buf, PAGE_SIZE, "%u\n", tool_action);

}



static ssize_t toolaction_store(struct device *dev,

static ssize_t toolaction_store(struct device *dev,

				struct device_attribute *attr,

				struct device_attribute *attr,

				const char *buf, size_t count);

				const char *buf, size_t count)

{

	u8 tool_action;

	int ret;



	if (kstrtou8(buf, 10, &tool_action))

		return -EINVAL;



	ret = visorchannel_write

		(controlvm_channel,

		 offsetof(struct spar_controlvm_channel_protocol,

			  tool_action),

		 &tool_action, sizeof(u8));



	if (ret)

		return ret;

	return count;

}

static DEVICE_ATTR_RW(toolaction);

static DEVICE_ATTR_RW(toolaction);





static ssize_t boottotool_show(struct device *dev,

static ssize_t boottotool_show(struct device *dev,
@@ -431,39 +458,6 @@ parser_string_get(struct parser_context *ctx) 
	return value;

	return value;

}

}





static ssize_t toolaction_show(struct device *dev,

			       struct device_attribute *attr,

			       char *buf)

{

	u8 tool_action = 0;



	visorchannel_read(controlvm_channel,

			  offsetof(struct spar_controlvm_channel_protocol,

				   tool_action), &tool_action, sizeof(u8));

	return scnprintf(buf, PAGE_SIZE, "%u\n", tool_action);

}



static ssize_t toolaction_store(struct device *dev,

				struct device_attribute *attr,

				const char *buf, size_t count)

{

	u8 tool_action;

	int ret;



	if (kstrtou8(buf, 10, &tool_action))

		return -EINVAL;



	ret = visorchannel_write

		(controlvm_channel,

		 offsetof(struct spar_controlvm_channel_protocol,

			  tool_action),

		 &tool_action, sizeof(u8));



	if (ret)

		return ret;

	return count;

}



static ssize_t boottotool_show(struct device *dev,

static ssize_t boottotool_show(struct device *dev,

			       struct device_attribute *attr,

			       struct device_attribute *attr,

			       char *buf)

			       char *buf)