Commit 854b7737 authored by Colin Ian King's avatar Colin Ian King Committed by Herbert Xu
Browse files

crypto: sa2ul - Fix memory leak of rxd 



There are two error return paths that are not freeing rxd and causing
memory leaks.  Fix these.

Addresses-Coverity: ("Resource leak")
Fixes: 00c9211f ("crypto: sa2ul - Fix DMA mapping API usage")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 50274b01

drivers/crypto/sa2ul.c

+6 −2
Original line number Diff line number Diff line
@@ -1146,8 +1146,10 @@ static int sa_run(struct sa_req *req) 
		mapped_sg->sgt.sgl = src;

		mapped_sg->sgt.orig_nents = src_nents;

		ret = dma_map_sgtable(ddev, &mapped_sg->sgt, dir_src, 0);

		if (ret)

		if (ret) {

			kfree(rxd);

			return ret;

		}



		mapped_sg->dir = dir_src;

		mapped_sg->mapped = true;
@@ -1155,8 +1157,10 @@ static int sa_run(struct sa_req *req) 
		mapped_sg->sgt.sgl = req->src;

		mapped_sg->sgt.orig_nents = sg_nents;

		ret = dma_map_sgtable(ddev, &mapped_sg->sgt, dir_src, 0);

		if (ret)

		if (ret) {

			kfree(rxd);

			return ret;

		}



		mapped_sg->dir = dir_src;

		mapped_sg->mapped = true;