Commit 88438668 authored by Marek Vasut's avatar Marek Vasut Committed by Thomas Zimmermann
Browse files

drm/bridge: lvds-codec: Add support for pixel data sampling edge select 



The OnSemi FIN3385 Parallel-to-LVDS encoder has a dedicated input line to
select input pixel data sampling edge. Add DT property "pclk-sample", not
the same as the one used by display timings but rather the same as used by
media, and configure bus flags based on this DT property.

Signed-off-by: default avatarMarek Vasut <marex@denx.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org
To: dri-devel@lists.freedesktop.org
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20211017001204.299940-2-marex@denx.de
parent d7df3948

drivers/gpu/drm/bridge/lvds-codec.c

+15 −0
Original line number Diff line number Diff line
@@ -21,6 +21,7 @@ struct lvds_codec { 
	struct device *dev;

	struct drm_bridge bridge;

	struct drm_bridge *panel_bridge;

	struct drm_bridge_timings timings;

	struct regulator *vcc;

	struct gpio_desc *powerdown_gpio;

	u32 connector_type;
@@ -119,6 +120,7 @@ static int lvds_codec_probe(struct platform_device *pdev) 
	struct device_node *bus_node;

	struct drm_panel *panel;

	struct lvds_codec *lvds_codec;

	u32 val;

	int ret;



	lvds_codec = devm_kzalloc(dev, sizeof(*lvds_codec), GFP_KERNEL);
@@ -187,12 +189,25 @@ static int lvds_codec_probe(struct platform_device *pdev) 
		}

	}



	/*

	 * Encoder might sample data on different clock edge than the display,

	 * for example OnSemi FIN3385 has a dedicated strapping pin to select

	 * the sampling edge.

	 */

	if (lvds_codec->connector_type == DRM_MODE_CONNECTOR_LVDS &&

	    !of_property_read_u32(dev->of_node, "pclk-sample", &val)) {

		lvds_codec->timings.input_bus_flags = val ?

			DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE :

			DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE;

	}



	/*

	 * The panel_bridge bridge is attached to the panel's of_node,

	 * but we need a bridge attached to our of_node for our user

	 * to look up.

	 */

	lvds_codec->bridge.of_node = dev->of_node;

	lvds_codec->bridge.timings = &lvds_codec->timings;

	drm_bridge_add(&lvds_codec->bridge);



	platform_set_drvdata(pdev, lvds_codec);