Commit 8920157a authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

auxdisplay: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers 



The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do
not set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v2:
	* fix commit message (Miguel)

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Acked-by: default avatarMiguel Ojeda <ojeda@kernel.org>
Cc: Miguel Ojeda <ojeda@kernel.org>
Cc: Robin van der Gracht <robin@protonic.nl>
Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-10-tzimmermann@suse.de
parent 0e007891

drivers/auxdisplay/cfag12864bfb.c

+0 −1
Original line number Diff line number Diff line
@@ -79,7 +79,6 @@ static int cfag12864bfb_probe(struct platform_device *device) 
	info->var = cfag12864bfb_var;

	info->pseudo_palette = NULL;

	info->par = NULL;

	info->flags = FBINFO_FLAG_DEFAULT;



	if (register_framebuffer(info) < 0)

		goto fballoced;

drivers/auxdisplay/ht16k33.c

+0 −1
Original line number Diff line number Diff line
@@ -646,7 +646,6 @@ static int ht16k33_fbdev_probe(struct device *dev, struct ht16k33_priv *priv, 
	fbdev->info->var = ht16k33_fb_var;

	fbdev->info->bl_dev = bl;

	fbdev->info->pseudo_palette = NULL;

	fbdev->info->flags = FBINFO_FLAG_DEFAULT;

	fbdev->info->par = priv;



	err = register_framebuffer(fbdev->info);