Commit 897f5504 authored by Dmitry Baryshkov's avatar Dmitry Baryshkov
Browse files

drm/msm: drop register logging support 



Register logging was used during early stages of msm driver development
to compare upstream and downstream register traces. However the tool was
never updated to work with mdp5 hardware. Later it was dropped
completely when Rob imported freedreno tools into mesa. All this makes
DRM_MSM_REGISTER_LOGGING irrelevant now, so it can be dropped.

Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarStephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20220105232700.444170-1-dmitry.baryshkov@linaro.org


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent 5333f0ec

drivers/gpu/drm/msm/Kconfig

+0 −9
Original line number Diff line number Diff line
@@ -33,15 +33,6 @@ config DRM_MSM_GPU_STATE 
	depends on DRM_MSM && (DEBUG_FS || DEV_COREDUMP)

	default y



config DRM_MSM_REGISTER_LOGGING

	bool "MSM DRM register logging"

	depends on DRM_MSM

	default n

	help

	  Compile in support for logging register reads/writes in a format

	  that can be parsed by envytools demsm tool.  If enabled, register

	  logging can be switched on via msm.reglog=y module param.



config DRM_MSM_GPU_SUDO

	bool "Enable SUDO flag on submits"

	depends on DRM_MSM && EXPERT

drivers/gpu/drm/msm/msm_drv.c

+1 −15
Original line number Diff line number Diff line
@@ -57,14 +57,6 @@ static const struct drm_mode_config_helper_funcs mode_config_helper_funcs = { 
	.atomic_commit_tail = msm_atomic_commit_tail,

};



#ifdef CONFIG_DRM_MSM_REGISTER_LOGGING

static bool reglog;

MODULE_PARM_DESC(reglog, "Enable register read/write logging");

module_param(reglog, bool, 0600);

#else

#define reglog 0

#endif



#ifdef CONFIG_DRM_FBDEV_EMULATION

static bool fbdev = true;

MODULE_PARM_DESC(fbdev, "Enable fbdev compat layer");
@@ -150,9 +142,6 @@ static void __iomem *_msm_ioremap(struct platform_device *pdev, const char *name 
		return ERR_PTR(-ENOMEM);

	}



	if (reglog)

		printk(KERN_DEBUG "IO:region %s %p %08lx\n", dbgname, ptr, size);



	if (psize)

		*psize = size;
@@ -179,16 +168,13 @@ void __iomem *msm_ioremap_size(struct platform_device *pdev, const char *name, 


void msm_writel(u32 data, void __iomem *addr)

{

	if (reglog)

		printk(KERN_DEBUG "IO:W %p %08x\n", addr, data);

	writel(data, addr);

}



u32 msm_readl(const void __iomem *addr)

{

	u32 val = readl(addr);

	if (reglog)

		pr_err("IO:R %p %08x\n", addr, val);



	return val;

}