Commit 89ad19be authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam
Browse files

bus: mhi: host: pci_generic: Sort mhi_pci_id_table based on the PID 



Sorting this way helps in identifying the products of vendors. There is no
sorting required for VID and the new VID should be added as the last entry.

Let's also add a note clarifying this.

Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: default avatarDaniele Palmas <dnlplm@gmail.com>
Link: https://lore.kernel.org/r/20220411133428.42165-1-manivannan.sadhasivam@linaro.org


Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
parent e565d3ef

drivers/bus/mhi/host/pci_generic.c

+5 −4
Original line number Diff line number Diff line
@@ -446,20 +446,21 @@ static const struct mhi_pci_dev_info mhi_sierra_em919x_info = { 
	.sideband_wake = false,

};



/* Keep the list sorted based on the PID. New VID should be added as the last entry */

static const struct pci_device_id mhi_pci_id_table[] = {

	{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0304),

		.driver_data = (kernel_ulong_t) &mhi_qcom_sdx24_info },

	/* EM919x (sdx55), use the same vid:pid as qcom-sdx55m */

	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x18d7, 0x0200),

		.driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info },

	{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0306),

		.driver_data = (kernel_ulong_t) &mhi_qcom_sdx55_info },

	{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0304),

		.driver_data = (kernel_ulong_t) &mhi_qcom_sdx24_info },

	{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0308),

		.driver_data = (kernel_ulong_t) &mhi_qcom_sdx65_info },

	{ PCI_DEVICE(0x1eac, 0x1001), /* EM120R-GL (sdx24) */

		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },

	{ PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */

		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },

	{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0308),

		.driver_data = (kernel_ulong_t) &mhi_qcom_sdx65_info },

	/* T99W175 (sdx55), Both for eSIM and Non-eSIM */

	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),

		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },