Commit 8a6d92d7 authored by Kushal Kothari's avatar Kushal Kothari Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: core: Remove true and false comparison 



Remove comparison to true and false in if statement.
Issue found with checkpatch.pl.
CHECK: Using comparison to true is error prone
CHECK: Using comparison to false is error prone

Signed-off-by: default avatarKushal Kothari <kushalkothari285@gmail.com>
Link: https://lore.kernel.org/r/47dd38847c4e36742f88f4493773fef602ca079b.1634967010.git.kushalkothari285@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 96381a77

drivers/staging/rtl8723bs/core/rtw_cmd.c

+11 −11
Original line number Diff line number Diff line
@@ -371,7 +371,7 @@ void rtw_free_cmd_obj(struct cmd_obj *pcmd) 
void rtw_stop_cmd_thread(struct adapter *adapter)

{

	if (adapter->cmdThread &&

		atomic_read(&(adapter->cmdpriv.cmdthd_running)) == true &&

		atomic_read(&(adapter->cmdpriv.cmdthd_running)) &&

		adapter->cmdpriv.stop_req == 0) {

		adapter->cmdpriv.stop_req = 1;

		complete(&adapter->cmdpriv.cmd_queue_comp);
@@ -542,7 +542,7 @@ u8 rtw_sitesurvey_cmd(struct adapter *padapter, struct ndis_802_11_ssid *ssid, 
	struct cmd_priv 	*pcmdpriv = &padapter->cmdpriv;

	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;



	if (check_fwstate(pmlmepriv, _FW_LINKED) == true)

	if (check_fwstate(pmlmepriv, _FW_LINKED))

		rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_SCAN, 1);



	ph2c = rtw_zmalloc(sizeof(struct cmd_obj));
@@ -775,7 +775,7 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct wlan_network *pnetwork) 
	/*  If not,  we have to copy the connecting AP's MAC address to it so that */

	/*  the driver just has the bssid information for PMKIDList searching. */



	if (pmlmepriv->assoc_by_bssid == false)

	if (!pmlmepriv->assoc_by_bssid)

		memcpy(&pmlmepriv->assoc_bssid[0], &pnetwork->network.mac_address[0], ETH_ALEN);



	psecnetwork->ie_length = rtw_restruct_sec_ie(padapter, &pnetwork->network.ies[0], &psecnetwork->ies[0], pnetwork->network.ie_length);
@@ -1164,7 +1164,7 @@ u8 rtw_set_chplan_cmd(struct adapter *padapter, u8 chplan, u8 enqueue, u8 swconf 
	u8 res = _SUCCESS;



	/*  check if allow software config */

	if (swconfig && rtw_hal_is_disable_sw_channel_plan(padapter) == true) {

	if (swconfig && rtw_hal_is_disable_sw_channel_plan(padapter)) {

		res = _FAIL;

		goto exit;

	}
@@ -1250,7 +1250,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer) 
	/*  */

	/*  Determine if our traffic is busy now */

	/*  */

	if ((check_fwstate(pmlmepriv, _FW_LINKED) == true)

	if ((check_fwstate(pmlmepriv, _FW_LINKED))

		/*&& !MgntInitAdapterInProgress(pMgntInfo)*/) {

		/*  if we raise bBusyTraffic in last watchdog, using lower threshold. */

		if (pmlmepriv->LinkDetectInfo.bBusyTraffic)
@@ -1342,7 +1342,7 @@ static void dynamic_chk_wk_hdl(struct adapter *padapter) 


	pmlmepriv = &(padapter->mlmepriv);



	if (check_fwstate(pmlmepriv, WIFI_AP_STATE) == true)

	if (check_fwstate(pmlmepriv, WIFI_AP_STATE))

		expire_timeout_chk(padapter);



	/* for debug purpose */
@@ -1377,8 +1377,8 @@ void lps_ctrl_wk_hdl(struct adapter *padapter, u8 lps_ctrl_type) 
	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);

	u8 mstatus;



	if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) == true)

		|| (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) {

	if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) ||

		(check_fwstate(pmlmepriv, WIFI_ADHOC_STATE))) {

		return;

	}
@@ -1386,7 +1386,7 @@ void lps_ctrl_wk_hdl(struct adapter *padapter, u8 lps_ctrl_type) 
	case LPS_CTRL_SCAN:

		hal_btcoex_ScanNotify(padapter, true);



		if (check_fwstate(pmlmepriv, _FW_LINKED) == true) {

		if (check_fwstate(pmlmepriv, _FW_LINKED)) {

			/*  connect */

			LPS_Leave(padapter, "LPS_CTRL_SCAN");

		}
@@ -1512,7 +1512,7 @@ static void rtw_lps_change_dtim_hdl(struct adapter *padapter, u8 dtim) 
	if (dtim <= 0 || dtim > 16)

		return;



	if (hal_btcoex_IsBtControlLps(padapter) == true)

	if (hal_btcoex_IsBtControlLps(padapter))

		return;



	mutex_lock(&pwrpriv->lock);
@@ -1840,7 +1840,7 @@ static void c2h_wk_callback(struct work_struct *work) 
			continue;

		}



		if (ccx_id_filter(c2h_evt) == true) {

		if (ccx_id_filter(c2h_evt)) {

			/* Handle CCX report here */

			rtw_hal_c2h_handler(adapter, c2h_evt);

			kfree(c2h_evt);