Commit 8c47b825 authored by Rob Herring's avatar Rob Herring Committed by Thierry Reding
Browse files

firmware: Use of_property_present() for testing DT property presence 



It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Acked-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent 60b3a99a

drivers/firmware/arm_scmi/optee.c

+1 −1
Original line number Diff line number Diff line
@@ -403,7 +403,7 @@ static int setup_static_shmem(struct device *dev, struct scmi_chan_info *cinfo, 
static int setup_shmem(struct device *dev, struct scmi_chan_info *cinfo,

		       struct scmi_optee_channel *channel)

{

	if (of_find_property(cinfo->dev->of_node, "shmem", NULL))

	if (of_property_present(cinfo->dev->of_node, "shmem"))

		return setup_static_shmem(dev, cinfo, channel);

	else

		return setup_dynamic_shmem(dev, channel);

drivers/firmware/tegra/bpmp.c

+3 −3
Original line number Diff line number Diff line
@@ -764,19 +764,19 @@ static int tegra_bpmp_probe(struct platform_device *pdev) 
	if (err < 0)

		goto free_mrq;



	if (of_find_property(pdev->dev.of_node, "#clock-cells", NULL)) {

	if (of_property_present(pdev->dev.of_node, "#clock-cells")) {

		err = tegra_bpmp_init_clocks(bpmp);

		if (err < 0)

			goto free_mrq;

	}



	if (of_find_property(pdev->dev.of_node, "#reset-cells", NULL)) {

	if (of_property_present(pdev->dev.of_node, "#reset-cells")) {

		err = tegra_bpmp_init_resets(bpmp);

		if (err < 0)

			goto free_mrq;

	}



	if (of_find_property(pdev->dev.of_node, "#power-domain-cells", NULL)) {

	if (of_property_present(pdev->dev.of_node, "#power-domain-cells")) {

		err = tegra_bpmp_init_powergates(bpmp);

		if (err < 0)

			goto free_mrq;