Commit 8c5eee30 authored by Mohammed Gamal's avatar Mohammed Gamal Committed by Avi Kivity
Browse files

KVM: x86 emulator: Fix emulate_grp3 return values 



This patch lets emulate_grp3() return X86EMUL_* return codes instead
of hardcoded ones.

Signed-off-by: default avatarMohammed Gamal <m.gamal005@gmail.com>
Signed-off-by: default avatarAvi Kivity <avi@redhat.com>
parent 3f9f53b0

arch/x86/kvm/emulate.c

+3 −3
Original line number Diff line number Diff line
@@ -1424,9 +1424,9 @@ static inline int emulate_grp3(struct x86_emulate_ctxt *ctxt, 
		emulate_1op_rax_rdx("idiv", c->src, *rax, *rdx, ctxt->eflags);

		break;

	default:

		return 0;

		return X86EMUL_UNHANDLEABLE;

	}

	return 1;

	return X86EMUL_CONTINUE;

}



static inline int emulate_grp45(struct x86_emulate_ctxt *ctxt,
@@ -3172,7 +3172,7 @@ x86_emulate_insn(struct x86_emulate_ctxt *ctxt) 
		ctxt->eflags ^= EFLG_CF;

		break;

	case 0xf6 ... 0xf7:	/* Grp3 */

		if (!emulate_grp3(ctxt, ops))

		if (emulate_grp3(ctxt, ops) != X86EMUL_CONTINUE)

			goto cannot_emulate;

		break;

	case 0xf8: /* clc */