Commit 8cc5e62b authored by ye xingchen's avatar ye xingchen Committed by Lee Jones
Browse files

mfd: Use sysfs_emit() to instead of scnprintf() 



Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: default avatarye xingchen <ye.xingchen@zte.com.cn>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/202212021528368292334@zte.com.cn
parent 5ec32a3e

drivers/mfd/kempld-core.c

+3 −4
Original line number Diff line number Diff line
@@ -349,7 +349,7 @@ static ssize_t pld_version_show(struct device *dev, 
{

	struct kempld_device_data *pld = dev_get_drvdata(dev);



	return scnprintf(buf, PAGE_SIZE, "%s\n", pld->info.version);

	return sysfs_emit(buf, "%s\n", pld->info.version);

}



static ssize_t pld_specification_show(struct device *dev,
@@ -357,8 +357,7 @@ static ssize_t pld_specification_show(struct device *dev, 
{

	struct kempld_device_data *pld = dev_get_drvdata(dev);



	return scnprintf(buf, PAGE_SIZE, "%d.%d\n", pld->info.spec_major,

		       pld->info.spec_minor);

	return sysfs_emit(buf, "%d.%d\n", pld->info.spec_major, pld->info.spec_minor);

}



static ssize_t pld_type_show(struct device *dev,
@@ -366,7 +365,7 @@ static ssize_t pld_type_show(struct device *dev, 
{

	struct kempld_device_data *pld = dev_get_drvdata(dev);



	return scnprintf(buf, PAGE_SIZE, "%s\n", kempld_get_type_string(pld));

	return sysfs_emit(buf, "%s\n", kempld_get_type_string(pld));

}



static DEVICE_ATTR_RO(pld_version);

drivers/mfd/lm3533-core.c

+1 −1
Original line number Diff line number Diff line
@@ -286,7 +286,7 @@ static ssize_t show_output(struct device *dev, 


	val = (val & mask) >> shift;



	return scnprintf(buf, PAGE_SIZE, "%u\n", val);

	return sysfs_emit(buf, "%u\n", val);

}



static ssize_t store_output(struct device *dev,