Commit 8cc80c60 authored by Robert Foss's avatar Robert Foss Committed by Mauro Carvalho Chehab
Browse files

media: camss: vfe: Don't read hardware version needlessly 



vfe_set_power() is invoked a few times, which causes a lot of
VFE HW version prints.

Secondly there is no real reason for calling hw_version_read() from
this location specifically, since it does nothing more than print
the VFE HW version.

A better location for the hw_version_read() call would be somewhere
which is only executed once per VFE unit.

Signed-off-by: default avatarRobert Foss <robert.foss@linaro.org>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent ecf8d36f

drivers/media/platform/qcom/camss/camss-vfe.c

+1 −2
Original line number Diff line number Diff line
@@ -713,8 +713,6 @@ static int vfe_set_power(struct v4l2_subdev *sd, int on) 
		ret = vfe_get(vfe);

		if (ret < 0)

			return ret;



		vfe->ops->hw_version_read(vfe, vfe->camss->dev);

	} else {

		vfe_put(vfe);

	}
@@ -1301,6 +1299,7 @@ int msm_vfe_subdev_init(struct camss *camss, struct vfe_device *vfe, 
		return -EINVAL;

	}

	vfe->ops->subdev_init(dev, vfe);

	vfe->ops->hw_version_read(vfe, dev);



	/* Memory */