Commit 8d507812 authored by Mukesh Sisodiya's avatar Mukesh Sisodiya Committed by Johannes Berg
Browse files

wifi: iwlwifi: mvm: Handle return value for iwl_mvm_sta_init 



sta_init function can fail and if it returns an error then
driver should not send the request to fw to add a station.

Fixes: 69aef848 ("wifi: iwlwifi: mvm: refactor iwl_mvm_add_sta(), iwl_mvm_rm_sta()")
Signed-off-by: default avatarMukesh Sisodiya <mukesh.sisodiya@intel.com>
Signed-off-by: default avatarGregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230612184434.1ecd293539e8.I5ec6aab387bb2fe743a7402581beaeb9c801d31f@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 3f244876

drivers/net/wireless/intel/iwlwifi/mvm/sta.c

+2 −0
Original line number Diff line number Diff line
@@ -1859,6 +1859,8 @@ int iwl_mvm_add_sta(struct iwl_mvm *mvm, 


	ret = iwl_mvm_sta_init(mvm, vif, sta, sta_id,

			       sta->tdls ? IWL_STA_TDLS_LINK : IWL_STA_LINK);

	if (ret)

		goto err;



update_fw:

	ret = iwl_mvm_sta_send_to_fw(mvm, sta, sta_update, sta_flags);