Commit 8ef228c2 authored by Lai Jiangshan's avatar Lai Jiangshan Committed by Sean Christopherson
Browse files

KVM: x86/mmu: Set mmu->sync_page as NULL for direct paging 



mmu->sync_page for direct paging is never called.

And both mmu->sync_page and mm->invlpg only make sense in shadow paging.
Setting mmu->sync_page as NULL for direct paging makes it consistent
with mm->invlpg which is set NULL for the case.

Signed-off-by: default avatarLai Jiangshan <jiangshan.ljs@antgroup.com>
Link: https://lore.kernel.org/r/20230216154115.710033-5-jiangshanlai@gmail.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent 51dddf6c

arch/x86/kvm/mmu/mmu.c

+2 −8
Original line number Diff line number Diff line
@@ -1789,12 +1789,6 @@ static void mark_unsync(u64 *spte) 
	kvm_mmu_mark_parents_unsync(sp);

}



static int nonpaging_sync_page(struct kvm_vcpu *vcpu,

			       struct kvm_mmu_page *sp)

{

	return -1;

}



#define KVM_PAGE_ARRAY_NR 16



struct kvm_mmu_pages {
@@ -4510,7 +4504,7 @@ static void nonpaging_init_context(struct kvm_mmu *context) 
{

	context->page_fault = nonpaging_page_fault;

	context->gva_to_gpa = nonpaging_gva_to_gpa;

	context->sync_page = nonpaging_sync_page;

	context->sync_page = NULL;

	context->invlpg = NULL;

}
@@ -5198,7 +5192,7 @@ static void init_kvm_tdp_mmu(struct kvm_vcpu *vcpu, 
	context->cpu_role.as_u64 = cpu_role.as_u64;

	context->root_role.word = root_role.word;

	context->page_fault = kvm_tdp_page_fault;

	context->sync_page = nonpaging_sync_page;

	context->sync_page = NULL;

	context->invlpg = NULL;

	context->get_guest_pgd = get_cr3;

	context->get_pdptr = kvm_pdptr_read;