Commit 91c4431b authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Bjorn Andersson
Browse files

arm64: dts: qcom: sc8280xp: align TLMM pin configuration with DT schema 



DT schema expects TLMM pin configuration nodes to be named with
'-state' suffix and their optional children with '-pins' suffix.

  qcom/sc8280xp-crd.dtb: pinctrl@f100000: kybd-default-state: 'oneOf' conditional failed, one must be fixed:
    'pins' is a required property
    'function' is a required property
    'disable', 'int-n', 'reset' do not match any of the regexes: 'pinctrl-[0-9]+'
    'disable', 'int-n', 'reset' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'

Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@somainline.org>
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20220930192954.242546-4-krzysztof.kozlowski@linaro.org
parent 7ff4a646

arch/arm64/boot/dts/qcom/sc8280xp-crd.dts

+6 −6
Original line number Diff line number Diff line
@@ -374,19 +374,19 @@ &tlmm { 
	gpio-reserved-ranges = <74 6>, <83 4>, <125 2>, <128 2>, <154 7>;



	kybd_default: kybd-default-state {

		disable {

		disable-pins {

			pins = "gpio102";

			function = "gpio";

			output-low;

		};



		int-n {

		int-n-pins {

			pins = "gpio104";

			function = "gpio";

			bias-disable;

		};



		reset {

		reset-pins {

			pins = "gpio105";

			function = "gpio";

			bias-disable;
@@ -410,7 +410,7 @@ qup2_i2c5_default: qup2-i2c5-default-state { 
	};



	tpad_default: tpad-default-state {

		int-n {

		int-n-pins {

			pins = "gpio182";

			function = "gpio";

			bias-disable;
@@ -418,13 +418,13 @@ int-n { 
	};



	ts0_default: ts0-default-state {

		int-n {

		int-n-pins {

			pins = "gpio175";

			function = "gpio";

			bias-disable;

		};



		reset-n {

		reset-n-pins {

			pins = "gpio99";

			function = "gpio";

			output-high;

arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts

+6 −6
Original line number Diff line number Diff line
@@ -350,19 +350,19 @@ &tlmm { 
	gpio-reserved-ranges = <70 2>, <74 6>, <83 4>, <125 2>, <128 2>, <154 7>;



	kybd_default: kybd-default-state {

		disable {

		disable-pins {

			pins = "gpio102";

			function = "gpio";

			output-low;

		};



		int-n {

		int-n-pins {

			pins = "gpio104";

			function = "gpio";

			bias-disable;

		};



		reset {

		reset-pins {

			pins = "gpio105";

			function = "gpio";

			bias-disable;
@@ -384,7 +384,7 @@ qup2_i2c5_default: qup2-i2c5-default-state { 
	};



	tpad_default: tpad-default-state {

		int-n {

		int-n-pins {

			pins = "gpio182";

			function = "gpio";

			bias-disable;
@@ -392,13 +392,13 @@ int-n { 
	};



	ts0_default: ts0-default-state {

		int-n {

		int-n-pins {

			pins = "gpio175";

			function = "gpio";

			bias-disable;

		};



		reset-n {

		reset-n-pins {

			pins = "gpio99";

			function = "gpio";

			output-high;