Commit 91dce409 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Kalle Valo
Browse files

wifi: ath11k: Use list_count_nodes() 



ath11k_wmi_fw_stats_num_vdevs() and ath11k_wmi_fw_stats_num_bcn() really
look the same as list_count_nodes(), so use the latter instead of hand
writing it.

The first ones use list_for_each_entry() and the other list_for_each(), but
they both count the number of nodes in the list.

While at it, also remove to prototypes of non-existent functions.
Based on the names and prototypes, it is likely that they should be
equivalent to list_count_nodes().

Compile tested only.

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Signed-off-by: default avatarKalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/941484caae24b89d20524b1a5661dd1fd7025492.1682542084.git.christophe.jaillet@wanadoo.fr
parent fd7bc9d9

drivers/net/wireless/ath/ath11k/wmi.c

+1 −23
Original line number Diff line number Diff line
@@ -6548,28 +6548,6 @@ int ath11k_wmi_pull_fw_stats(struct ath11k_base *ab, struct sk_buff *skb, 
				   &parse);

}



size_t ath11k_wmi_fw_stats_num_vdevs(struct list_head *head)

{

	struct ath11k_fw_stats_vdev *i;

	size_t num = 0;



	list_for_each_entry(i, head, list)

		++num;



	return num;

}



static size_t ath11k_wmi_fw_stats_num_bcn(struct list_head *head)

{

	struct ath11k_fw_stats_bcn *i;

	size_t num = 0;



	list_for_each_entry(i, head, list)

		++num;



	return num;

}



static void

ath11k_wmi_fw_pdev_base_stats_fill(const struct ath11k_fw_stats_pdev *pdev,

				   char *buf, u32 *length)
@@ -6880,7 +6858,7 @@ void ath11k_wmi_fw_stats_fill(struct ath11k *ar, 
	}



	if (stats_id == WMI_REQUEST_BCN_STAT) {

		num_bcn = ath11k_wmi_fw_stats_num_bcn(&fw_stats->bcn);

		num_bcn = list_count_nodes(&fw_stats->bcn);



		len += scnprintf(buf + len, buf_len - len, "\n");

		len += scnprintf(buf + len, buf_len - len, "%30s (%zu)\n",

drivers/net/wireless/ath/ath11k/wmi.h

+0 −3
Original line number Diff line number Diff line
@@ -6372,9 +6372,6 @@ int ath11k_wmi_send_pdev_set_regdomain(struct ath11k *ar, 
				       struct pdev_set_regdomain_params *param);

int ath11k_wmi_pull_fw_stats(struct ath11k_base *ab, struct sk_buff *skb,

			     struct ath11k_fw_stats *stats);

size_t ath11k_wmi_fw_stats_num_peers(struct list_head *head);

size_t ath11k_wmi_fw_stats_num_peers_extd(struct list_head *head);

size_t ath11k_wmi_fw_stats_num_vdevs(struct list_head *head);

void ath11k_wmi_fw_stats_fill(struct ath11k *ar,

			      struct ath11k_fw_stats *fw_stats, u32 stats_id,

			      char *buf);