Commit 92548b0e authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

ipv4: fix endianness issue in inet_rtm_getroute_build_skb() 



The UDP length field should be in network order.
This removes the following sparse error:

net/ipv4/route.c:3173:27: warning: incorrect type in assignment (different base types)
net/ipv4/route.c:3173:27:    expected restricted __be16 [usertype] len
net/ipv4/route.c:3173:27:    got unsigned long

Fixes: 404eb77e ("ipv4: support sport, dport and ip_proto in RTM_GETROUTE")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Roopa Prabhu <roopa@nvidia.com>
Cc: David Ahern <dsahern@kernel.org>
Reviewed-by: default avatarDavid Ahern <dsahern@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 616920a6

net/ipv4/route.c

+1 −1
Original line number Diff line number Diff line
@@ -3165,7 +3165,7 @@ static struct sk_buff *inet_rtm_getroute_build_skb(__be32 src, __be32 dst, 
		udph = skb_put_zero(skb, sizeof(struct udphdr));

		udph->source = sport;

		udph->dest = dport;

		udph->len = sizeof(struct udphdr);

		udph->len = htons(sizeof(struct udphdr));

		udph->check = 0;

		break;

	}